On Tue, Mar 12, 2013 at 10:14 AM, K. Peachey <p858snake(a)gmail.com> wrote:
On Wed, Mar 13, 2013 at 2:43 AM, Greg Grossmeier
<greg(a)wikimedia.org> wrote:
4) A Gerrit-based tagging plugin would need some
engineering that might
not be apparent at first blush, for example: who can set tags and remove
them? Does that vary by tag? How could I, for example, keep track of all
scaptrap-type things and be sure I don't miss something because someone
mistakenly removed the scaptrap tag from a merge and I didn't
notice/remember (ie: can I *trust* the tag, both what is there and what
isn't, so I don't have to remember everything/double check every week?).
I don't think we need to be that granular with the tagging permissions, In
CR we used to just have it so you needed the Coder right, And i'm not aware
of many instances where tagging was abused. You just need to have some sort
of "version" of whom added/removed the tags.
Although there were instances where people forgot to tag changes, But that
is unavoidable no matter what level(/s) of permissions you have.
While I agree that we can model our permissions after what we did with
the old SVN/MediaWiki code review system, I'll note that there were
some other features that made this more complicated under the hood,
such as keeping a history of who tagged what. It's all stuff we've
done before in MediaWiki, which is likely part of the reason Chad was
tempted to do it there, but doing it in Gerrit may end up being more
complicated.
Rob