Briefly:
* Brion was copy'n'paste happy today ;-)
* "Works for me" = "Works on my computer if I look at HTML with mark 1
eyeball, but does not pass the parser test". PHP 4.something, tell you
tomorrow. Will check under PHP5
* "You liked producing invalid XML? :) " - Sure! :-) Except the only
underscore-to-space conversion (which was suppsed to be the error)
occured in the title attribute of the link, which I changed...
Tomorrow starts the "hot phase" of carnival here in Cologne. Still
thinking about costume. Maybe I'll wrap myself in some USB cables, glue
on a laser pointer, shave my head and go as Borg. Maybe not.
Magnus
Brion Vibber wrote:
Magnus Manske wrote:
I didn't get around to fix the parser test,
but here's my current
analysis, by looking at the HTML output manually:
An automated run of parserTests.php showed the
following failures:
Running test BUG 361: URL within URL, not bracketed... FAILED!
Works for me.
Works how?
Does it:
1) Pass the test on your computer?
2) Not pass the test on your computer?
If 1), try again with PHP 5.1.2 and see if it's the same or changed.
If 2), what makes you think it works?
Running
test External links: invalid character... FAILED!
Fixed. I liked the previous behaviour better, though.
You liked producing invalid XML? :)
Running
test A table with no data.... FAILED!
Parser test expects blank, parser (now) generates
<table><tr><td></td></tr></table>, which is valid as
well.
Blank output might require major hack. So, works for me.
Works how?
Does it:
1) Pass the test on your computer?
2) Not pass the test on your computer?
If 1), try again with PHP 5.1.2 and see if it's the same or changed.
If 2), what makes you think it works?
Running
test A table with nothing but a caption... FAILED!
Works for me.
Works how?
Does it:
1) Pass the test on your computer?
2) Not pass the test on your computer?
If 1), try again with PHP 5.1.2 and see if it's the same or changed.
If 2), what makes you think it works?
Running
test Magic links: PMID incorrectly converts space to underscore... FAILED!
Fixed, I guess...
Fixed how?
Does it:
1) Pass the test on your computer?
2) Not pass the test on your computer?
If 1), try again with PHP 5.1.2 and see if it's the same or changed.
If 2), what makes you think it's fixed?
Running
test Simple category... FAILED!
Works for me.
Works how?
Does it:
1) Pass the test on your computer?
2) Not pass the test on your computer?
If 1), try again with PHP 5.1.2 and see if it's the same or changed.
If 2), what makes you think it's fixed?
-- brion vibber (brion @
pobox.com)
------------------------------------------------------------------------
_______________________________________________
Wikitech-l mailing list
Wikitech-l(a)wikimedia.org
http://mail.wikipedia.org/mailman/listinfo/wikitech-l