[Engineering] Gerrit now automatically adds reviewers

Ariel Glenn WMF ariel at wikimedia.org
Fri Jan 18 14:26:29 UTC 2019


In the meantime, I would encourage those who have not looked at the Git
Reviewer Bot page in a while, to do so and to add any updates.

Ariel

On Fri, Jan 18, 2019 at 4:12 PM Tyler Cipriani <tcipriani at wikimedia.org>
wrote:

> Hi all,
>
> Gerrit no longer automatically adds reviewers[0]. Unfortunately, this
> plugin appears (given the replies on this thread) to be missing key
> features needed to be useful for us at this time. Apologies to those
> folks whose inboxes were destroyed.
>
> I would like to re-enable this plugin at some point, provided the
> features identified in this thread are added (perhaps also an
> "X-Gerrit-reviewers-by-blame: 1" email header, or subject line to make
> filtering these messages easier).
>
> In the interim, project-owners are able to opt-in to using the
> reviewers-by-blame plugin on a per-project basis on their project admin
> page in Gerrit.
>
> Also, the Git Reviewer Bot[1] provides folks an opt-in method of
> volunteering to review a subset of files in a particular repo.
>
> Getting code review as a new contributor is hard. Thanks for bearing
> with us.
>
> -- Tyler
>
> [0]. <https://gerrit.wikimedia.org/r/#/c/All-Projects/+/485184/>
> [1]. <https://www.mediawiki.org/wiki/Git/Reviewers>
>
> On 19-01-17 13:51:58, Greg Grossmeier wrote:
> >Hello,
> >
> >Yesterday we (the Release Engineering team) enabled a Gerrit plugin that
> >will automatically add reviewers to your changes based on who previously
> >has committed changes to the file.
> >
> >For more, please read the blog post at:
> >
> https://phabricator.wikimedia.org/phame/post/view/139/gerrit_now_automatically_adds_reviewers/
> >
> >NOTE: There are a couple requests from us open upstream to improve the
> >plugin[0], we'll incorporate those improvements when they are released.
> >
> >On behalf of the rest of the Release Engineering Team[1],
> >
> >Greg
> >
> >[0] https://phabricator.wikimedia.org/T101131#4890023
> >[1] As well as Paladox, a Wikimedia volunteer with strong ties to
> >upstream Gerrit.
> >
> >--
> >| Greg Grossmeier            GPG: B2FA 27B1 F7EB D327 6B8E |
> >| Release Team Manager            A18D 1138 8E47 FAC8 1C7D |
> >
> >_______________________________________________
> >Engineering mailing list
> >Engineering at lists.wikimedia.org
> >https://lists.wikimedia.org/mailman/listinfo/engineering
> _______________________________________________
> Engineering mailing list
> Engineering at lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/engineering
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.wikimedia.org/pipermail/engineering/attachments/20190118/7f4dc2f4/attachment.html>


More information about the Engineering mailing list