[Engineering] [varnishkafka] RFC switch to VUT API for varnish 5.2+ support

Mon Apr 16 05:58:09 UTC 2018

Hello,

Oh, I did not know you used Phabricator. Ok so I will update the task
with my observations about the change.

Best regards,

Diego Abelenda

On 04/13/2018 04:49 PM, Luca Toscano wrote:
> Hi Diego,
>
> 2018-04-13 16:23 GMT+02:00 Diego Abelenda
> <diego.abelenda at camptocamp.com <mailto:diego.abelenda at camptocamp.com>>:
>
>     Hello,
>
>     I am sorry if this is not the correct mailing list to discuss this.
>
>
>     At Camptocamp we are using varnishkafka, and we are looking to upgrade
>     to varnish 5.2, however since Varnish broke the VSM API we will
>     need to
>     change varnishkafka too.
>
>     Since they decided to make VUT API public, I was thinking of switching
>     varnishkafka to it. Hopefully this API will be more stable than
>     VSM API.
>
>     This would basically transform the whole while block into a single
>     call
>     to VUT_Main() with a slightly modified dispatch function and some call
>     to VUT_Init/VUT_Setup correct params
>     (https://github.com/wikimedia/varnishkafka/blob/master/varnishkafka.c#L2150-L2195
>     <https://github.com/wikimedia/varnishkafka/blob/master/varnishkafka.c#L2150-L2195>).
>
>     The only blocking point I can see, is the call to rd_kafka_poll which
>     will need to be made somehow outside of the "main" thread since
>     VUT_Main
>     is a main loop (a periodic call via timer/thread with a while and
>     blocking call?).
>
>     I have only analyzed the possibility but not started coding. I
>     prefer to
>     have some input first, what do you think of this proposal?
>
>
> Thanks a lot for reaching out, I opened a while ago a similar task
> (https://phabricator.wikimedia.org/T177647) and the idea was exactly
> what you proposed, namely switching to VUT and make the necessary
> changes for with Varnish 5.2. We still don't have a clear timeline
> if/when we'll migrate to Varnish 5.2 as far as I know, so the work got
> a bit de-prioritized, but we can definitely have a chat on IRC or in
> the Phabricator task about next steps and ideas if you wish.
>
> Luca 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.wikimedia.org/pipermail/engineering/attachments/20180416/2a3586f6/attachment.html>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.wikimedia.org/pipermail/engineering/attachments/20180416/2a3586f6/attachment.sig>