Yes I realise, I was mainly doing this out of a personal interest. Of
course before I started this I was not aware of how big the
performance impact would be. I still think the new Diff has added
value with the greedy heuristic for large documents. The PHP
implementation is used on small default installs and they can have big
documents too. Not getting an out of memory error, or having timeouts
is useful there.
2008/8/5 Simetrical <Simetrical+wikilist(a)gmail.com>om>:
On Tue, Aug 5, 2008 at 3:55 PM, Guy Van den Broeck
<guyvdb(a)gmail.com> wrote:
I can't draw any final conclusions with
respect to performance because
I don't have a site of considerable size. I'd appreciate it if
somebody could test this implementation and compare it to the current
php installation.
Any site of considerable size is likely to be running wikidiff2, which
is written in C++ and almost certainly much faster than your PHP
implementation. (Or did you really mean that your PHP code is faster
than the C++ library?) So if your target is big sites, you shouldn't
have written it in PHP.
Diffing is not a significant bottleneck at present with wikidiff2,
however, so a rewrite for performance reasons alone is unlikely to be
productive. I imagine the Wikimedia sysadmins (for instance) would be
uninterested in trying out new solutions when an established one works
perfectly well.
_______________________________________________
Wikitech-l mailing list
Wikitech-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l