On 23 December 2012 17:35, Tyler Romeo <tylerromeo(a)gmail.com> wrote:
This is a bad idea. It defies the concept of what +1
and +2 mean. Also, +1
permissions are given to literally everybody, so any two developers could
override the opinion of the repository maintainer.
I'd phrase that the other way around: the way +1 and +2 are used now
defies the concept of what +1 and +2 actually mean: they are numbers,
so twice +1 should be the same as +2 (after all, 1+1=2). The concept
are 'looks good to me' and 'approved' (and 'no opinion' and
'do not
submit'), and I would suggest to name them something else than +1 and
+2 (as well was 0 and -1 -- those also imply you can just add up the
opinions). Simply using 'Approved', 'OK', 'Comment' and
'Problem' is
simple enough, I'd think.
Merlijn