On Tue, Apr 15, 2008 at 11:46 AM, Roan Kattouw <roan.kattouw(a)home.nl> wrote:
There aren't any in includes/api, except .svn,
which shouldn't be counted.
Well, my count seems to be more correct than yours *somehow*:
$ find includes/api -iregex '^.*\.\(php\|inc\)$' -exec grep '^\s*{' {} + |
head
includes/api/ApiQueryUserContributions.php: {
includes/api/ApiQueryUserContributions.php: {
includes/api/ApiQueryAllimages.php: {
includes/api/ApiPageSet.php: {
includes/api/ApiPageSet.php: {
includes/api/ApiPageSet.php: {
includes/api/ApiPageSet.php: {
includes/api/ApiPageSet.php: {
includes/api/ApiQueryBlocks.php: {
includes/api/ApiQueryBlocks.php: {
There's not just one, in other words. grepping includes/api/*.php
gets me the same count, 111.
I don't. It's just that there are multiple
acceptable variations on the
general coding style (I believe the CODING-STYLE file explicitly says
that it's OK to use a slightly deviating style, as long as you don't do
very weird things) which are used in the core as well as in the API;
it's just that the distribution of these styles in the API is very
different from the distribution in the rest of the core.
Well, yes. But de facto, we've adopted the K&R brace style
overwhelmingly. I certainly change any deviations if I see them. It
looks ugly to have different styles used throughout the code, whether
or not there's any document that declares one style or another as
preferable.