On 5/30/08, Rotem Liss <rotemliss(a)gmail.com> wrote:
http://svn.wikimedia.org/viewvc/mediawiki/trunk/extensions/CentralAuth/Cent…
in function chooseHomeWiki( $migrationSet ),
why not check for blocked account like this?,
$maxEdits = -1;
$homeWiki = null;
foreach( $workingSet as $wiki => $local ) {
if( $local['editCount'] > $maxEdits &&
!$local['blocked'])
{ # <-- added code here
$homeWiki = $wiki;
$maxEdits = $local['editCount'];
}
}
It was already done in a similar way. I changed it to disallow migration if
the user in the home wiki is blocked (no similar restrictions on the other
users seem to be set). The main problem with the previous behavior was in
the following situation: two users with the same user name want the global
name. The user with more edits is blocked for a while. Now the second user's
account is the home account, and he can merge his accounts unfairly, because
of a block which may be temporary (e.g. for 3RR). The current behavior fixes
The fairness may not be a good reason,
since using sysop status and edit count to choose the home wiki is also unfair.
If we not skip the temporarily blocked account, just because it is unfair,
then we must also not use sysop status nor edit count to choose the
home wiki, since they are also unfair.
I just want to state that nothing is fair.
We should have the more acceptable reason (than fairness reason) to
say why we shouldn't skip the temporarily blocked account.
it and doesn't allow migration when the home wiki
is blocked; however,
migrating while another account (which is not the home account) is blocked
is possible. For more details and discussion, see
https://bugzilla.wikimedia.org/show_bug.cgi?id=11149 .