-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Roan Kattouw wrote:
Add an API
module that can be POSTed to to trigger a codereview repo update
+ $repo = CodeRepository::newFromName( $params['repo'] );
+ if( !$repo ){
+ throw new MWException( "Invalid repo {$args[0]}" );
+ }
Throwing an MWException on invalid input is not very nice. You should
really use something like:
Yeah, I was too lazy to investigate how to do it right. The response
isn't examined at all by the caller right now, so I had no rush. ;)
Thanks for the tips!
- -- brion
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.8 (Darwin)
Comment: Using GnuPG with Mozilla -
http://enigmail.mozdev.org
iEYEARECAAYFAkjk98cACgkQwRnhpk1wk47JAACgkvCNw9AN/FnrIYPdfGhVs/1O
Tv0An1gry0K2B1xtKPR0q//MI5ne9zSg
=U31v
-----END PGP SIGNATURE-----