Le 22/07/2015 13:39, Petr Bena a écrit :
Good job, you aren't the only one. Huggle team is
using it for quite
some time. To be honest I still feel that github is far superior to
our gerrit installation and don't really understand why we don't use
it for other projects too.
There are a few reasons for not using GitHub that I keep mentioning:
* We need a reliable git services we can act on with minimum latency.
The reason we migrated out of SourceForge svn was because of some hours
of outage that prevented us from fixing the live site.
* The GitHub term of services [1] has a few restrictions that prevent
some our community members from contributing:
** You must be 13 years or older to use this Service.
** You must be a human. Accounts registered by "bots" or other automated
methods are not permitted.
At one point I think they requested you to put your real name.
[1]
https://help.github.com/articles/github-terms-of-service/
But the real reason is why rely on a 3rd party when we can do it
ourselves? Lot of old timers feel we should self host as much as possible.
The GitHub's pull requests are more compliant with
original git
philosophy of Linus, see this video:
https://www.youtube.com/watch?v=4XpnKHJAok8 and would be sufficient
replacement to our current "git-review" mechanism, which is very
complex and unfriendly to new developers who probably find it very
difficult to use.
I haven't watched the hour long video but I can quite a comment from
Linus explaining why he would not honor pull requests on the linux
GitHub project:
---------8<---------8<---------8<---------8<---------8<---------
Linus wrote:
I don't do github pull requests.
github throws away all the relevant information, like having even a
valid email address for the person asking me to pull. The diffstat is
also deficient and useless.
Git comes with a nice pull-request generation module, but github
instead decided to replace it with their own totally inferior version.
As a result, I consider github useless for these kinds of things. It's
fine for *hosting*, but the pull requests and the online commit
editing, are just pure garbage.
I've told github people about my concerns, they didn't think they
mattered, so I gave up. Feel free to make a bugreport to github.
---------8<---------8<---------8<---------8<---------8<---------
So in short the pull requests merge are quite awful and drop most of the
context.
Git built-in mechanism is
http://git-scm.com/docs/git-request-pull
Original:
https://github.com/torvalds/linux/pull/17#issuecomment-5654674
Linus followed up with more details in subsequent replies.
If you don't like git-review, which we borrowed from OpenStack and
serves thousands of professional developers there, feel free to amend it
or create your own wrapper on top of git push refs/for/<branch>
--
Antoine "hashar" Musso