On Mon, Jun 28, 2010 at 8:13 AM, Thomas Dalton <thomas.dalton(a)gmail.com>wrote;wrote:
Ok, how about alternative D?
D:
1) Display diff between A1 and P1.
2) P1 is rejected. Nothing happens to the database at this point, the
rejection of P1 is just remembered somewhere.
3) Display a diff between A1 and "P2 minus A1P1 delta" (that can be
created temporarily using the undo feature)
4a) If that diff is rejected, display a diff between A1 and "P3 minus
A1P2 delta" (or equivalently, "P3 minus A1P1 delta minus P1P2 delta").
4b) If that diff (in 3) is accepted, display a diff between "P2 minus
A1P1 delta" and "P3 minus A1P1 delta".
5) Continue in what I hope is the obvious fashion, because I'm
thoroughly confused!
6) Create a revision equal to that latest accepted pseudo-revision and
mark it as accepted.
This will be a mess to program (and no, I'm not volunteering!), but it
should be very intuitive for the reviewer. If at any time the undo
feature can't create one of the pseudo-revisions (the ones in quotes),
you just fail gracefully.
What do you think?
Hi Thomas,
I think this may be the way we could have done this if we were designing the
feature from scratch (and it may be something to consider for a major
rewrite, should we embark on that), but given the scope of changes we should
probably make at this point, I'm guessing we'll probably need to table this
particular suggestion.
In general, I think you're touching on what is (what I think) is the really
common desire here, which is that if people go through the trouble of
reviewing a diff, and it's bad, they want some way of flagging a delta as
bad, rather than implicitly rejecting it through jumping through some hoops.
However, as Gregory would point out, that's just not the way the software
is currently designed. I think we should still figure out the best way(s)
to accommodate this desire, but I hesitate to go so far as adding a new flag
in the database for rejected revisions.
It wouldn't hurt to document this as an alternative for a possible redesign,
though.
PS The aspirin is in the second drawer on the left!
Thanks, I'll need it ;-)
Rob