[Pywikibot-commits] [Gerrit] pywikibot/core[master]: Revert "Set minimum requirement of websocket-client"

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/339807 ) Change subject: Revert "Set minimum requirement of websocket-client" ...................................................................... Revert "Set minimum requirement of websocket-client" Pywikibot does not depend on a particular version of websocket-client; in fact it does not even interact directly with its API. Stating a requirement on a particular version because some bug was fixed there has the disadvantage that it disallows previous versions to be used where the bug did not occur (< 0.27.0), and it also prevents backporting fixes (0.27.1 or 0.27.0~local_patch). This change reverts commit b96e7f57905751c08a0b5c5197d47dff3bcfe182. Change-Id: Ie2ba76cf0280dc095539c6b2648adc5e67085782 --- M requirements.txt M setup.py 2 files changed, 1 insertion(+), 5 deletions(-) Approvals: jenkins-bot: Verified Xqt: Looks good to me, approved diff --git a/requirements.txt b/requirements.txt index 83761b3..5c5183f 100644 --- a/requirements.txt +++ b/requirements.txt @@ -56,9 +56,6 @@ google >= 1.7 socketIO-client<0.6.1 -# websocket-client>=0.33 is required by socketIO-client (T114913) -websocket-client>=0.33 - # scripts/script_wui.py: crontab diff --git a/setup.py b/setup.py index a1323c5..2ba209d 100644 --- a/setup.py +++ b/setup.py @@ -61,8 +61,7 @@ 'mwparserfromhell': ['mwparserfromhell>=0.3.3'], 'Tkinter': ['Pillow'], # 0.6.1 supports socket.io 1.0, but WMF is using 0.9 (T91393 and T85716) - # websocket-client>=0.33 is required by socketIO-client (T114913) - 'rcstream': ['socketIO-client<0.6.1', 'websocket-client>=0.33'], + 'rcstream': ['socketIO-client<0.6.1'], 'security': ['requests[security]', 'pycparser!=2.14'], 'mwoauth': ['mwoauth>=0.2.4'], 'html': ['BeautifulSoup4'], -- To view, visit https://gerrit.wikimedia.org/r/339807 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2ba76cf0280dc095539c6b2648adc5e67085782 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Tim Landscheidt &lt;tim(a)tim-landscheidt.de&gt; Gerrit-Reviewer: Anoopchandu18 &lt;anoopchandu96(a)gmail.com&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Magul &lt;tomasz.magulski(a)gmail.com&gt; Gerrit-Reviewer: Tim Landscheidt &lt;tim(a)tim-landscheidt.de&gt; Gerrit-Reviewer: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: jenkins-bot <>