DrTrigon has posted comments on this change.
Change subject: improvement; change external simplejson from git submodule to internal
management
......................................................................
Patch Set 1:
@Ladsgroup: 1) I had no time to include the externals handling into core yet. 2) Regarding
compat, a few 2 or 3 submodules are there and can be cloned directly by using
'--recursive', the other python modules needed get downloaded on first use by
externals/__init__.py - so to answer your question; submodules HAVE TO, the others CAN be
included into nightlies, later will be downloaded anyway if not included.
@Merlijn, Xqt: Ok I will change this patch in order to completely remove simplejson (from
both submodule and externals/__init__.py). But first I have to make 'git review -d
ID' working on my machine, sorry for the delay!
--
To view, visit
https://gerrit.wikimedia.org/r/76350
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic0e2e9ca1c631088674fff7728e9a82df88bcf22
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/compat
Gerrit-Branch: master
Gerrit-Owner: DrTrigon <dr.trigon(a)surfeu.ch>
Gerrit-Reviewer: DrTrigon <dr.trigon(a)surfeu.ch>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Legoktm <legoktm.wikipedia(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: PywikibotCommitWatcher <pywikibot-commits(a)lists.wikimedia.org>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-HasComments: No