XZise has posted comments on this change.
Change subject: WIP: Replacing old Bugzilla tickets with Phab.
......................................................................
Patch Set 1:
(4 comments)
https://gerrit.wikimedia.org/r/#/c/234734/1//COMMIT_MSG
Commit Message:
Line 14: number, so it's clear it's a Phabricator task. I tag this as work in
In the end only the last patch set will get committed. And that shouldn't be WIP and
thus contain this note. If you want to add additional information for the reviewers post
it as a comment. But after the merge this last sentence is unnecessary.
Also both John and I mentioned on the bug how we got the results:
git grep -i bugzilla
git grep -iE 'bug *[1-9]'
You could probably improve the second one with something like:
git grep -iE "bug\W*[1-9]"
https://gerrit.wikimedia.org/r/#/c/234734/1/pywikibot/data/api.py
File pywikibot/data/api.py:
Line 1785: # bug 66619 (T68619), after gerrit 124323 breaking change we have a
Why do you keep “bug 66619”? Also “gerrit 124323” is not a good identifier. Maybe “after
1ca9cee3 (Wikibase)”.
https://gerrit.wikimedia.org/r/#/c/234734/1/pywikibot/exceptions.py
File pywikibot/exceptions.py:
Line 293: This is considered invalid in Pywikibot. See Bug T75184.
lowercase bug?
https://gerrit.wikimedia.org/r/#/c/234734/1/tests/site_tests.py
File tests/site_tests.py:
Line 608: # Bug # T17985 - reverse and start combined; fixed in v 1.14
I guess the second # was used as “number” which does seem odd (and afaik any other
instances use “bug T…”).
--
To view, visit
https://gerrit.wikimedia.org/r/234734
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib775bfdbc96311ccb09ad9a1ee77b9970c09fd43
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: MarcoAurelio <strigiwm(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: PywikibotCommitWatcher <pywikibot-commits(a)lists.wikimedia.org>
Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de>
Gerrit-Reviewer: jenkins-bot <>
Gerrit-HasComments: Yes