[Pywikibot-commits] [Gerrit] pywikibot/core[master]: [bugfix] User.is_thankable() should not be true for unregist...

jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/401487 ) Change subject: [bugfix] User.is_thankable() should not be true for unregistered users ...................................................................... [bugfix] User.is_thankable() should not be true for unregistered users Bug: T183875 Change-Id: I2af214f5ed601a50ead9a470e8c76ab5bcb1ddd2 --- M pywikibot/page.py M tests/user_tests.py 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Framawiki: Verified; Looks good to me, approved jenkins-bot: Verified diff --git a/pywikibot/page.py b/pywikibot/page.py index 1291d4e..5195af2 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -12,7 +12,7 @@ """ # -# (C) Pywikibot team, 2008-2017 +# (C) Pywikibot team, 2008-2018 # # Distributed under the terms of the MIT license. # @@ -3529,6 +3529,8 @@ """ if self.isAnonymous(): return False + if not self.isRegistered(): + return False if 'bot' in self.groups(): return False diff --git a/tests/user_tests.py b/tests/user_tests.py index 7ba2dd9..1ffb626 100644 --- a/tests/user_tests.py +++ b/tests/user_tests.py @@ -1,7 +1,7 @@ # -*- coding: utf-8 -*- """Tests for the User page.""" # -# (C) Pywikibot team, 2016 +# (C) Pywikibot team, 2016-2018 # # Distributed under the terms of the MIT license. # @@ -68,6 +68,7 @@ self.assertGreater(user.editCount(), 0) self.assertEqual(user.gender(), 'male') self.assertIn('userid', user.getprops()) + self.assertTrue(user.is_thankable) def test_female_user(self): """Test female user.""" @@ -77,6 +78,7 @@ self.assertGreater(user.editCount(), 0) self.assertEqual(user.gender(), 'female') self.assertIn('userid', user.getprops()) + self.assertTrue(user.is_thankable) def test_anonymous_user(self): """Test registered user.""" @@ -104,6 +106,7 @@ self.assertFalse(user.isEmailable()) self.assertEqual(user.gender(), 'unknown') self.assertIn('missing', user.getprops()) + self.assertFalse(user.is_thankable) def test_invalid_user(self): """Test invalid user.""" @@ -117,6 +120,7 @@ self.assertFalse(user.isEmailable()) self.assertEqual(user.gender(), 'unknown') self.assertIn('invalid', user.getprops()) + self.assertFalse(user.is_thankable) if __name__ == '__main__': # pragma: no cover -- To view, visit https://gerrit.wikimedia.org/r/401487 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2af214f5ed601a50ead9a470e8c76ab5bcb1ddd2 Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Framawiki &lt;framawiki(a)tools.wmflabs.org&gt; Gerrit-Reviewer: Framawiki &lt;framawiki(a)tools.wmflabs.org&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: Zoranzoki21 &lt;zorandori4444(a)gmail.com&gt; Gerrit-Reviewer: jenkins-bot <>