On Mon, Oct 13, 2014 at 7:08 PM, Jon Robson <jrobson(a)wikimedia.org> wrote:
This is awesome.
:D
Rather than MMV depending on MobileFrontend, if we
want to make this
work on mobile I imagine a better thing to do would be to make it
dependent on Extension:Mantle [1] since Mantle currently provides the
templates that this would need and is a much more lightweight
extension to add as a dependency.
For the moment I'm actually inheriting directly from MobileFrontend's
ImageOverlay class for the MediaOverlay. But this might be too fragile a
coupling.
As for lightweight/heavyweight dependency; the mobile overlay is only used
within MobileFrontend's interface right now. But I'm thinking long-term
might want to rework the whole TimedMediaHandler MwEmbedPlayer front-end in
a cleaner way that eventually gives us a universal zoomable, overlayable
media player overlay.
Not quite sure where to work things in with MMV too; possibly MMV needs a
hook point that TMH can extend with just the video player portion?
This could be a great opportunity to move Overlay.js from
MobileFrontend to extension Mantle and try and begin
consolidating
MediaViewer, MobileFrontend, VE and Flow's Overlay/Modal JS and css
code here. We already successfully began porting MobileFrontend's
class system to OOJS so this would give us an opportunity to reduce
some of MediaWiki's code debt relating to overlays and move closer to
a unified OOUI modal/overlay thing. I'd be interested in looking at
how OOUI's Modals and MobileFrontend's Overlay differ.
That sounds good but lots of work. :D
Would there be some kind of hook so MobileFrontend can give a consistent
'mobile style' to the overlays versus desktop views, or would we try to
make a single overlay UI that works well on both?
-- brion