small edit problem updating to 1.4.5 solved?

List overview All Threads
Download

newer

older

Is there some tool to convert HTML...

Server downtime today

Pablo Chamorro C.

4 Jun 2005 4 Jun '05

5:26 a.m.

I decided to update my media wiki 1.4.4 to 1.4.5 but the 'save' button didn't work any more. The apache log gave this error: [client 192.168.x.x] PHP Fatal error: Call to undefined function: pinglimiter() in /var/www/html/mediawiki-1.4.5/includes/EditPage.php on line 214, referer: http://intranet.mydomain/wiki?title=...&action=submit I compared EditPage.php from media wiki 1.4.4/5 with this result: 214,217d213 < if ( $wgUser->pingLimiter() ) { < $wgOut->rateLimited(); < return; < } 500c496 < $editsummary="{$summary}: <input tabindex='2' type='text' value=\"$summarytext\" name=\"wpSummary\" maxlength='200' size='60' /><br />"; ---

...

$editsummary="{$summary}: <input

tabindex='3' type='text' value=\"$summarytext\" name=\"wpSummary\" maxlength='200' size='60' /><br />"; So, I decided to use the previous EditPage.php version and like this I was able to save again. My question is: perhaps is this a bug? or an php or php-mysql specific problem? Thanks, Pablo Chamorro C. -- Tel: +57 (2) 7314752/3222/2595 - Fax: +57 (2) 7310514 Carrera 31 #18-07 Parque Infantil - PO Box 1795 - Pasto

Show replies by date

Brion Vibber

4 Jun 4 Jun

5:40 a.m.

New subject: [Mediawiki-l] small edit problem updating to 1.4.5 solved?

Pablo Chamorro C. wrote:

...

Did you somehow forget to update User.php? -- brion vibber (brion @ pobox.com)

Pablo Chamorro C.

7:08 p.m.

New subject: [Mediawiki-l] small edit problem updating to 1.4.5 solved?

...

[client 192.168.x.x] PHP Fatal error: Call to undefined function: pinglimiter() in /var/www/html/mediawiki-1.4.5/includes/EditPage.php on line 214, referer: http://intranet.mydomain/wiki?title=...&action=submit

Did you somehow forget to update User.php?

No, I updated extracting over the old files as I did from 1.4.2 a 1.4.4 and now to 1.4.5. Thanks, Pablo Chamorro C.

...

-- brion vibber (brion @ pobox.com)

-- Tel: +57 (2) 7314752/3222/2595 - Fax: +57 (2) 7310514 Carrera 31 #18-07 Parque Infantil - PO Box 1795 - Pasto

Brion Vibber

10:33 p.m.

New subject: [Mediawiki-l] small edit problem updating to 1.4.5 solved?

Pablo Chamorro C. wrote:

...

Did you somehow forget to update User.php?

No, I updated extracting over the old files as I did from 1.4.2 a 1.4.4 and now to 1.4.5.

Then I strongly recommend you take a look at the file and confirm that it's actually correct, because it sounds like it's loaded an old version of that file. User.php as shipped in 1.4.5 is 32637 bytes and has an MD5 checksum of d432f9281e124482d63303ee01a660dc. Check that you're not using the wrong $IP in your include path, such as a path pointing to old versions of the files. Using a pathname with the version in it is suspicious when you say you're "extracting over the old files". If you're using a PHP opcode cache system, try clearing it manually and/or editing the file to update its timestamp, to ensure an obsolete version of the User class definition isn't being used. -- brion vibber (brion @ pobox.com)

Pablo Chamorro C.

5 Jun 5 Jun

12:32 a.m.

New subject: [Mediawiki-l] small edit problem updating to 1.4.5 solved?

...

Check that you're not using the wrong $IP in your include path, such as a path pointing to old versions of the files. Using a pathname with the version in it is suspicious when you say you're "extracting over the old files".

oh, yeah :( that was the problem, I had: $IP = "/var/www/html/mediawiki-1.4.4"; and I lost a couple of hours trying to understand why the math part didn't work either until I realized of that! Sorry for this but is good information for other newbies like me.

...

If you're using a PHP opcode cache system, try clearing it manually and/or editing the file to update its timestamp, to ensure an obsolete version of the User class definition isn't being used.

Thanks!, I have to learn that too, Pablo

...

-- brion vibber (brion @ pobox.com)

-- Tel: +57 (2) 7314752/3222/2595 - Fax: +57 (2) 7310514 Carrera 31 #18-07 Parque Infantil - PO Box 1795 - Pasto

Jamie Bliss

4 Jun 4 Jun

10:33 p.m.

New subject: [Mediawiki-l] small edit problem updating to 1.4.5 solved?

On 6/4/05, Pablo Chamorro C. <pchamorro(a)ingeominas.gov.co> wrote:

...

No, I updated extracting over the old files as I did from 1.4.2 a 1.4.4 and now to 1.4.5.

You extracted over it? Then why in /var/www/html/mediawiki-1.4.5? -- Jamie ------------------------------------------------------------------- http://endeavour.zapto.org/astro73/ Thank you to JosephM for inviting me to Gmail! Have lots of invites. Gmail now has 2GB.

Pablo Chamorro C.

5 Jun 5 Jun

12:53 a.m.

New subject: [Mediawiki-l] small edit problem updating to 1.4.5 solved?

...

You extracted over it? Then why in /var/www/html/mediawiki-1.4.5?

I uncompressed the new mediawiki on a tmp directory first then I compressed the files without the mediawiki initial path and finally I uncompressed the resulting tgz. By the way somebody knows a tip for uncompress a mediawiki.tgz file directly to e.g. /var/www/html/wiki/ just with one command? I mean, without creating the initial mediawiki-1.4.5 directory path? Thanks, Pablo

...

-- Jamie ------------------------------------------------------------------- http://endeavour.zapto.org/astro73/ Thank you to JosephM for inviting me to Gmail! Have lots of invites. Gmail now has 2GB. _______________________________________________ MediaWiki-l mailing list MediaWiki-l(a)Wikimedia.org http://mail.wikipedia.org/mailman/listinfo/mediawiki-l

-- Tel: +57 (2) 7314752/3222/2595 - Fax: +57 (2) 7310514 Carrera 31 #18-07 Parque Infantil - PO Box 1795 - Pasto

Hínandil

12:58 a.m.

New subject: [Mediawiki-l] small edit problem updating to 1.4.5 solved?

Pablo Chamorro C. wrote:

...

By the way somebody knows a tip for uncompress a mediawiki.tgz file directly to e.g. /var/www/html/wiki/ just with one command? I mean, without creating the initial mediawiki-1.4.5 directory path?

Uh, how about: $ mv /var/www/html/wiki /var/www/html/wiki~ $ tar zvxf mediawiki-1.4.5.tar.gz $ mv mediawiki-1.4.5 /var/www/html/wiki That's what the team here likes to do. Come to think of it, that's what I do on my personal test server (when I don't start out with rm public_html/wiki anyway). Hínandil

Rick DeNatale

2:20 a.m.

New subject: [Mediawiki-l] small edit problem updating to 1.4.5 solved?

On 6/4/05, Hínandil <hinandil(a)freespirits.org> wrote:

...

Pablo Chamorro C. wrote:

By the way somebody knows a tip for uncompress a mediawiki.tgz file directly to e.g. /var/www/html/wiki/ just with one command? I mean, without creating the initial mediawiki-1.4.5 directory path?

Well that's not the one-liner that Pablo was asking for. It also doesn't do the whole job since you need to also move LocalSettings.php as well as an other extensions, AND your images directory, and whatever else I've forgotten. The upgrade instructions recommend backing up the old installation and then unpacking the new tarball into the old. it probably better to use copy or rsync to make a backup of the original directory, then do something like tar xzvr mediawiki-1.4.5.tar.gz mv -r mediawiki-1.4.5/* var/www/html/wiki rmdir mediawiki-1.4.5 I'd love to know how to do these three as one command, tar doesn't seem to have a way to extract an archive to a particular destination directory unless I'm missing it.

Sam Rowe

2:23 a.m.

New subject: [Mediawiki-l] small edit problem updating to 1.4.5 solved?

On Sat, Jun 04, 2005 at 10:20:09PM -0400, Rick DeNatale wrote: # On 6/4/05, H?nandil <hinandil(a)freespirits.org> wrote: # > Pablo Chamorro C. wrote: # > > By the way somebody knows a tip for uncompress a mediawiki.tgz file # > > directly to e.g. /var/www/html/wiki/ just with one command? I mean, # > > without creating the initial mediawiki-1.4.5 directory path? # > # > Uh, how about: # > # > $ mv /var/www/html/wiki /var/www/html/wiki~ # > $ tar zvxf mediawiki-1.4.5.tar.gz # > $ mv mediawiki-1.4.5 /var/www/html/wiki # > # > That's what the team here likes to do. Come to think of it, that's what # > I do on my personal test server (when I don't start out with rm # > public_html/wiki anyway). # # Well that's not the one-liner that Pablo was asking for. # # It also doesn't do the whole job since you need to also move # LocalSettings.php as well as an other extensions, AND your images # directory, and whatever else I've forgotten. The upgrade instructions # recommend backing up the old installation and then unpacking the new # tarball into the old. # # it probably better to use copy or rsync to make a backup of the # original directory, then do something like # # tar xzvr mediawiki-1.4.5.tar.gz # mv -r mediawiki-1.4.5/* var/www/html/wiki # rmdir mediawiki-1.4.5 $ ln -s wiki mediawiki-1.4.5 $ gzip -dc mediawiki-1.4.5.tar.gz | tar xf - $ rm mediawiki-1.4.5 Otherwise you lose all of your images, right? Make it a one-liner by separating the commands with && -Sam

Carlton B

7:44 a.m.

New subject: [Mediawiki-l] Failed adding Special:Wantedpages to navigation bar

When I tried to add Special:Wantedpages to the navigation bar, the link appears but it goes to a page called "--error:_link_target_missing--". This is for This is for 1.4.3. I followed the instructions to the letter, I think. The article MediaWiki:Wantedpages already existed, and contained the text "Wanted pages." This works OK. The article MediaWiki:Wantedpages-url did not exist. I created it with the text "Special:Wantedpage Here is what I have in my LocalSettings.php: $wgNavigationLinks = array ( array( 'text'=>'mainpage', 'href'=>'mainpage' ), array( 'text'=>'recentchanges', 'href'=>'recentchanges-url' ), array( 'text'=>'wantedpages', 'href'=>'wantedpages-url' ), # Change is here array( 'text'=>'randompage', 'href'=>'randompage-url' ), array( 'text'=>'portal', 'href'=>'portal-url' ), array( 'text'=>'currentevents', 'href'=>'currentevents-url' ), array( 'text'=>'help', 'href'=>'helppage' ), array( 'text'=>'sitesupport', 'href'=>'sitesupport-url' ), ); The first time I did this, someone may have retrieved the page before MediaWiki:Wantedpages-url existed. What could have happened here? Did I get a bad value cached somewhere? Thanks, Carlton

Carlton B

7:47 a.m.

New subject: [Mediawiki-l] Failed adding Special:Wantedpages to navigation bar

Typo in the previous... following sentence: "I created it with the text "Special:Wantedpage" should have been: "I created it with the text "Special:Wantedpages" I've corrected it in the copied message below.

...

-----Original Message----- From: mediawiki-l-bounces(a)Wikimedia.org [mailto:mediawiki-l-bounces@Wikimedia.org]On Behalf Of Carlton B Sent: Sunday, June 05, 2005 4:44 PM To: MediaWiki announcements and site admin list Subject: [Mediawiki-l] Failed adding Special:Wantedpages to navigation bar When I tried to add Special:Wantedpages to the navigation bar, the link appears but it goes to a page called "--error:_link_target_missing--". This is for This is for 1.4.3. I followed the instructions to the letter, I think. The article MediaWiki:Wantedpages already existed, and contained the text "Wanted pages." This works OK. The article MediaWiki:Wantedpages-url did not exist. I created it with the text "Special:Wantedpages Here is what I have in my LocalSettings.php: $wgNavigationLinks = array ( array( 'text'=>'mainpage', 'href'=>'mainpage' ), array( 'text'=>'recentchanges', 'href'=>'recentchanges-url' ), array( 'text'=>'wantedpages', 'href'=>'wantedpages-url' ), # Change is here array( 'text'=>'randompage', 'href'=>'randompage-url' ), array( 'text'=>'portal', 'href'=>'portal-url' ), array( 'text'=>'currentevents', 'href'=>'currentevents-url' ), array( 'text'=>'help', 'href'=>'helppage' ), array( 'text'=>'sitesupport', 'href'=>'sitesupport-url' ), ); The first time I did this, someone may have retrieved the page before MediaWiki:Wantedpages-url existed. What could have happened here? Did I get a bad value cached somewhere? Thanks, Carlton _______________________________________________ MediaWiki-l mailing list MediaWiki-l(a)Wikimedia.org http://mail.wikipedia.org/mailman/listinfo/mediawiki-l

Jamie Bliss

6 Jun 6 Jun

7:03 p.m.

New subject: [Mediawiki-l] Failed adding Special:Wantedpages to navigation bar

On 6/5/05, Carlton B <carltonb(a)mindspring.com> wrote:

...

Works for me. If you think it's a caching issue, try logging in (IIRC, full-page caching is only done with anonymous users). Make sure that [[MediaWiki:Wantedpages-url]] has this text: Special:Wantedpages Here's the code I added to LocalSettings.php: $wgNavigationLinks[] = array('text'=>'wantedpages', 'href'=>'wantedpages-url'); Does this help any? Are you using a non-english wiki? (Check the value of {{ns:-1}}) -- Jamie ------------------------------------------------------------------- http://endeavour.zapto.org/astro73/ Thank you to JosephM for inviting me to Gmail! Have lots of invites. Gmail now has 2GB.

Carlton B

10:29 p.m.

New subject: [Mediawiki-l] Failed adding Special:Wantedpages to navigation bar

...

-----Original Message----- From: mediawiki-l-bounces(a)Wikimedia.org [mailto:mediawiki-l-bounces@Wikimedia.org]On Behalf Of Jamie Bliss Sent: Tuesday, June 07, 2005 4:04 AM To: MediaWiki announcements and site admin list Subject: Re: [Mediawiki-l] Failed adding Special:Wantedpages to navigation bar On 6/5/05, Carlton B <carltonb(a)mindspring.com> wrote:

When I tried to add Special:Wantedpages to the navigation bar, the link appears but it goes to a page called

"--error:_link_target_missing--". This

is for This is for 1.4.3. I followed the instructions to the letter, I think. The article MediaWiki:Wantedpages already existed, and

contained the text

"Wanted pages." This works OK. The article MediaWiki:Wantedpages-url did not exist. I created

it with the

text "Special:Wantedpage Here is what I have in my LocalSettings.php: $wgNavigationLinks = array ( array( 'text'=>'mainpage', 'href'=>'mainpage' ), array( 'text'=>'recentchanges', 'href'=>'recentchanges-url' ), array( 'text'=>'wantedpages', 'href'=>'wantedpages-url' ), # Change is here array( 'text'=>'randompage', 'href'=>'randompage-url' ), array( 'text'=>'portal', 'href'=>'portal-url' ), array( 'text'=>'currentevents', 'href'=>'currentevents-url' ), array( 'text'=>'help', 'href'=>'helppage' ), array( 'text'=>'sitesupport',

'href'=>'sitesupport-url' ),

); The first time I did this, someone may have retrieved the page before MediaWiki:Wantedpages-url existed. What could have happened here? Did I get a bad value cached somewhere?

Thanks Jamie; I've tried what you still suggested and got nowhere. 1) {{ns:1}} is set to Special 2) Logging in had no effect 3) After reading yours and others' examples, I can confirm that I followed the instruction to the letter. After observing this over time, I can say that sometimes the menu is being substituted and sometimes it isn't. I'm having trouble reproducing it on demand, but it is intermittently happening. I am wondering if this is related to my as-yet unsolved issue where database message substitution only works once per 60 seconds and then resets the clock.

Carlton B

7 Jun 7 Jun

12:59 p.m.

New subject: [Mediawiki-l] Failed adding Special:Wantedpages to navigation bar

OK, it seems that when I disabled Turck support in LocalSettings.php, suddenly all my navigation links worked like magic. But I've got no caching at all now, and I'm a bit concerned about that. After inserting a few dozen log statements, I was able to isolate where (but not why) the problem occurs. Specifically, it's in ObjectCache.php, in the BagOTurckStuff class (nice confidence-inspiring name, BTW). The function mmcache_put() was claiming to succeed with a return value of 1, but for some reason the value didn't seem to be there when mmcache_get() tried to access it. I'm worried about going forward without some sort of caching solution. Can anybody give me pointers on why my Turck isn't turcking the way it should? I have no experience using or debugging it. Thanks, Carlton

Brion Vibber

1:16 p.m.

New subject: [Mediawiki-l] Failed adding Special:Wantedpages to navigation bar

Carlton B wrote:

...

OK, it seems that when I disabled Turck support in LocalSettings.php, suddenly all my navigation links worked like magic. But I've got no caching at all now, and I'm a bit concerned about that.

I would not recommend using the Turck object cache option on a production server; it hasn't been thoroughly tested. By default, the objectcache table in the database will be used for the message cache and the parser cache. Turck does an excellent job of caching compiled PHP code (this requires NO configuration in LocalSettings.php, as it's completely independent of our code), but it's less clear that trying to shove other data in it helps, and it's not well tested or used by us. If you really need the additional shared data caching (memcached sessions, cached user objects, other bits) or if the use of the objectcache table is a performance problem for you, consider using memcached. (Assuming you're running your own servers, have appropriate access control for network, etc.) -- brion vibber (brion @ pobox.com)

Carlton B

1:35 p.m.

New subject: [Mediawiki-l] Failed adding Special:Wantedpages to navigation bar

...

-----Original Message----- From: mediawiki-l-bounces(a)Wikimedia.org [mailto:mediawiki-l-bounces@Wikimedia.org]On Behalf Of Brion Vibber Sent: Tuesday, June 07, 2005 10:16 PM To: MediaWiki announcements and site admin list Subject: Re: [Mediawiki-l] Failed adding Special:Wantedpages to navigation bar Turck does an excellent job of caching compiled PHP code (this requires NO configuration in LocalSettings.php, as it's completely independent of our code), but it's less clear that trying to shove other data in it helps, and it's not well tested or used by us.

Thanks Brion... That being the case, I'd like to humbly suggest that MediaWiki should be distributed with $wgUseTurckShm set to false, and with sufficient comments of that particular feature's risks vs. benefits. I can only help my lost time will help someone else save time. -Carlton

Brion Vibber

1:52 p.m.

New subject: [Mediawiki-l] Failed adding Special:Wantedpages to navigation bar

Carlton B wrote:

...

That being the case, I'd like to humbly suggest that MediaWiki should be distributed with $wgUseTurckShm set to false, and with sufficient comments of that particular feature's risks vs. benefits. I can only help my lost time will help someone else save time.

It's off by default, and you have to deliberately switch it on. It probably shouldn't be presented as an option in the web installer, though. -- brion vibber (brion @ pobox.com)

Carlton B

9:55 a.m.

New subject: [Mediawiki-l] Failed adding Special:Wantedpages to navigation bar

Dumb question... in 1.4.3, does database message substitution work right out of the box, or do I have to turn it on somewhere? After inserting some print statments in various parts of the MW code, I can verify that nothing's getting substituted from the database, neither what I added, nor what came with the base product. It looks like it's all coming from language files.

...

When I tried to add Special:Wantedpages to the navigation bar, the link appears but it goes to a page called

"--error:_link_target_missing--". This

is for This is for 1.4.3. I followed the instructions to the letter, I think. The article MediaWiki:Wantedpages already existed, and

contained the text

"Wanted pages." This works OK. The article MediaWiki:Wantedpages-url did not exist. I created

it with the

'href'=>'sitesupport-url' ),

); The first time I did this, someone may have retrieved the page before MediaWiki:Wantedpages-url existed. What could have happened here? Did I get a bad value cached somewhere?

6934

days inactive

6937

days old

mediawiki-l@lists.wikimedia.org

Manage subscription

18 comments

7 participants

tags (0)

participants (7)

Brion Vibber
Carlton B
Hínandil
Jamie Bliss
Pablo Chamorro C.
Rick DeNatale
Sam Rowe