On Mon, Jan 6, 2014 at 1:08 PM, S Page <spage(a)wikimedia.org> wrote:
http://ee-flow-extra.instance-proxy.wmflabs.org/wiki/Special:UserLogin in
Firefox and Chromium. But the kss.doc is fine, so it's some interaction
with ResourceLoader and/or the CSS in other modules. I just noticed the
background color doesn't darken on active, as if &:active { background:
shade(@bgColor, 20%); } isn't working. According to my [Insert Agora
buttons] generator a page like
http://ee-flow-extra.instance-proxy.wmflabs.org/wiki/Main_Page doesn't
load other UI classes, so I'm not sure what's going on. I'll look at it
some more tonight.
Yeaaah. This definitely needs work. Some like Special:PasswordReset look
usable, but I would not release login or create account as-is.
Issues I can see:
- On login, when using a RTL language like Hebrew or Arabic, the right
button border is messed up somehow. See
http://ee-flow-extra.instance-proxy.wmflabs.org/wiki/Special:UserLogin?usel…
else see this?
- The login form now has a mix of center-aligned and right-aligned elements.
- On login secondary "Join" link is placed to left hand of the main submit
button. That makes no sense considering I read left-right in English. Also,
it needs to be an actual button, preferably a call to action, not a plain
link. This is probably going to require a bit of a redesign to incorporate
well.
- The main submit buttons seems a bit small. Probably should apply
mw-ui-big or something. Applying this in my console to create account seems
to work fine across languages.
Thanks for sharing on Labs S. You're the best.
One other thing I notice: this style for mw.ui really begs use of
placeholders instead of labels. Forms like Password reset etc. would look
so much cleaner.
--
Steven Walling,
Product Manager
https://wikimediafoundation.org/