On Mon, Sep 14, 2015 at 10:37 AM, C. Scott Ananian <cananian(a)wikimedia.org>
wrote:
On Mon, Sep 14, 2015 at 1:12 PM, Erik Bernhardson
<ebernhardson(a)wikimedia.org> wrote:
function oneIn(population) {
return Math.floor( Math.random() * populationSize ) === 0;
}
Perhaps 'population' in the function declaration should be
'populationSize'.
--scott
indeed i just typed this out off the top of my head, but the actual code
in prod
uses the right variable names :)
On Mon, Sep 14, 2015 at 10:46 AM, C. Scott Ananian <cananian(a)wikimedia.org>
wrote:
This actually puts 1/10,000 of your users in the test bucket, and
0.9999/10,000 in the control bucket.
What you really want is `else if ( oneIn( 9999 ) ) {` for the second
clause.
--scott
good catch, doesn't fix the overall problem but is a slight imbalance in
the data collection.