The following changes will be made without deprecation in gerrit
626548 <https://gerrit.wikimedia.org/r/c/mediawiki/core/+/626548>:
* FirejailCommand was removed. CodeSearch reveals no usages.
* Command::execute() now returns a Shellbox\Command\UnboxedResult
instead of a MediaWiki\Shell\Result. I added a class alias, but
type hints don't necessarily cause PHP to load the alias when it
parses the file, so any such type hints should be manually
updated. CodeSearch finds no affected code.
Context:
This is part of T260330 <https://phabricator.wikimedia.org/T260330>
"PHP microservice for containerized shell execution" a.k.a. Shellbox.
The patch moves the traditional shell execution code from MediaWiki to
the Shellbox library, and mildly refactors it. Rigorous backwards
compatibility was a goal of this change. We took the opportunity to
make a few minor interface changes, but we don't think anyone will be
affected.
-- Tim Starling
Show replies by date