Let me address my concerns step by step, as you obviously still don't grasp
what the major issue is.
Brandon wrote:
Here's what happened:
* I was asked to look at the bug as part of my 20% code review.
* I applied Erwin's patch (manually) and then played with changing
colors around to see what worked and what didn't.
* I tested everything in various color-blindness tools.
* I came to the conclusion that we could ONLY use yellow and blue because:
- Orange and blue vibrated next to each other.
- Yellow and purple vibrated next to each other.
- The use of green or red in any combination was not going to work
for a jillion reasons
- Blue and Purple turned into the same color with colorblindness
filters on.
- Ergo, Yellow and Blue, with orange-ish highlights.
Why didn't you test the original blue/green? What were your findings on
that? You should have applied the colors as present in the patch, as these
were the colors agreen upon in the original commit, which were blue for
deleted content, and green for added content. Those had been tested by
various users, both color-blind and not.
The yellow is *unchanged*
Which is the first issue I raised as a response to your commit; Noting wrong
with yellow per se, but the OLD yellow completely clashes with the NEW blue
that was originally intended and taken from the French colors. The yellow
completely overpowered the blue, as the hue and brighness levels are totally
incompatible. David Levy concurred with that assesment.
Does the "designer" in your sig denote any connection in graphic design? I
suspect not, as your choice in the combination of the yellow and blue
*combined* breaks just about any rules in web design. THAT is what I have
been trying to convey; NOT that yellow is wrong, but that is is the WRONG
yellow.
The blue is basically Erwin's blue except I might
have tapped it
around a bit to bump up contrast in certain places; I don't remember
exactly.
So. What was *supposed* to be a 15 minute task has now turned into a
drama - over something I don't really care that much about anyways.
You have yourself to blame for that. If you don't care that much, why are
you forcing your commit and subsequently try to stifle any follow-up
discussion by re-closing the bug report? We actually had a fruitfull
discussion before you came along. I even changed my patch to incorporate the
yellow you introduced.
This was an open bug. I was asked to address it. I
did. That's the end
of the story.
You were asked to REVIEW my patch, not to make unilateral changes and then
ignore any criticism on your changes might generate. If this were an edit in
Wikipedia's Common.css, you would have been reverted in a heartbeat.
To see what I'm talking about, have a look at
https://www.mediawiki.org/wiki/File:R106884-diff.png. The top line shows the
original proposed colors, the bottom line is Brandon's patch currently in
trunk. The ones in between are my versions based on Brandon's patch, after
taking several users' comments into account.
The only thing I care about is that the best code ends up in MediaWiki, and
not code that every project would want to override as soon as it is
deployed. Now, what I would simply like is for everyone just to look at the
colors and say which one they like best. That's all...
--
Erwin Dokter
