[Wikitech-l] Bad image list

On 30/06/06, brion(a)svn.leuksman.com <brion(a)svn.leuksman.com> wrote: Some thoughts on this...when I fixed whatever bug it was that caused galleries to ignore the bad image list, I considered doing this, however, I wondered whether it didn't quite make sense. The purpose of the bad image list as designed was to allow a few dodgy pictures to be specified and quietly suppressed upon parse actions. Leaving the fact that I don't support this behaviour in categories aside, I'm starting to think about whether or not we need to be storing this information elsewhere. A page with a bunch of regular expressions on it[1] that is evaluated in the manner the bad image list is...doesn't scale well if the administrators start adding several hundred/thousand odd images to it. It might be more effective to look at migrating this information to the database somewhere. As I see it, there's a few options springing to mind: 1. Add an extra column to the image metadata; treat it as a boolean value and use it to determine whether the image is bad 2. Add a whole new table for the purpose and introduce special pages to manipulate it 3. Similar to option two, but do it through an extension; don't make it part of the core code; expose the check via hooks in wfIsBadImage() Personal preferences lie with options two and three. We'd want logging for it, of course, but that is rather trivial. :) Anyway, just throwing out some thoughts, concerns and ideas... Rob Church