On Thu, Jul 08, 2004 at 03:35:15PM +0100, Timwi wrote:
I've also made it so that the <title> now
shows "Article title -
Information - Site name" as opposed to just "Article title - Site name",
so it is consistent with History.
While I was at it, I noticed missing or wrong <title>s when protect or
unprotect a page. I've fixed those too.
I'm attaching the entire patch again. I think it's committable like
this, although someone should still add an "info" tab to the skin or
else the info page is unreachable except by manually fiddling with the URL.
Okay,
here are my latest comments on the patch:
1. If there is a talk page, but no article, it says no article text and
does not report statistics for the talk page.
This does happen occasionly in wikipedia, for example:
http://en.wikipedia.org/wiki/Talk:M.R.M._Parrott
(Note that the UI gets this wrong in that the article like is blue, not
red in monobook style)
This can be fixed with a little rearranging of the order of the stats and
a } move.
2. If the article or the most recent user have a ' in their name,
the sql query errors out. I think this could be fixed by changing
the $wgTitle->getDBkey() to $dbr->addQuotes($wgTitle->getDBkey())
and the $cur_author to $dbr->addQuotes($cur_author)
3. Do the wfQuery's need fname? What exactly is fname?
4. As you noted, the info tab needs to be added.
5. Has any developer tried the querys on votes for deletion, or
some other article with lots of edits/authors to see how long the query takes?
Other than the ' problem, I think the patch is acceptable.
--
Josh Cogliati