[WikiEN-l] Re: Previews

Sat Oct 29 21:33:01 UTC 2005

steven l. rubenstein wrote:
> Half the time I click on "Save Page" the next screen is a "Preview" (and 
> my edits are not yet saved).

I think the main problem here is that there explicitly exists a code 
path that allows for a preview to be generated even if we know full well 
that "Save" was clicked, not "Preview". Supposedly there are some 
situations in which the preview is legitimately supposed to appear even 
when the user clicked "Save"; the problem is that these situations are 
either not well-defined, or their definition is so subtle as to make the 
behaviour unpredictable for end-users, effectively rendering it a bug.

I think not only the easiest but also the best solution to the problem 
would be to just kill that code path and always save if Save was 
clicked, even if it means saving it under an IP when the user thought 
they were logged in.

Maybe there are good reasons for the behaviour that I don't know, in 
which case maybe it would make sense to sit down and formalise the 
expected behaviour and then re-design the relevant code logic.

Timwi