[teampractices] Patch review culture of Wikimedia teams

Fri Mar 18 12:21:19 UTC 2016

Hej,

thanks for the reply!

On Tue, 2016-03-15 at 17:20 -0700, Kevin Smith wrote:
> TPG generally focuses on process and inter-personal issues, and
> doesn't get into the tech itself. 
> So our focus tends to be at the phab task level, rather than at the
> gerrit patch level.

As engineering tasks in Phabricator often require a code change going
through review, I'd consider code review a part of the process to get
Phabricator tasks resolved. 
Technical implementation details ("Gerrit") shouldn't be the main point
of my request - it's rather the social aspect of interaction between
authors and reviewers, and potentially documenting best practices
across teams performing code review as part of their usual processes.

Do you agree with that understanding?

> I think most TPGers happen to be embedded into teams that receive
> relatively few external code submissions. 

Let's ignore the "external contributions" aspect as I'd expect many
aspects of code review to also apply when reviewing internal
contributions.

Thanks,
andre

> I wonder whether integrating code review into phab will give us some
> new tools to help teams more easily monitor the flow of patches. I
> don't know what tools are available in gerrit. 
> 
> 
> 
> On Mon, Mar 14, 2016 at 6:19 AM, Andre Klapper <aklapper at wikimedia.org> wrote:
> > Thanks everybody for the comments! However I'm still curious if this is
> > part of the TPG scope, hence I'd welcome a reply from TPG members.
> > 
> > Thanks,
> > andre
> > 
> > On Mon, 2016-03-07 at 14:16 +0100, Andre Klapper wrote:
> > > https://phabricator.wikimedia.org/T101686 lists "Prioritization / weak
> > > open source culture: more pressure to write new code than to review
> > > patches contributed."
> > >
> > > Apart from whether that statement is true or not:
> > > Does the Team Practices Group encourage regular Gerrit patch backlog
> > > grooming? If so, how, and is there any documentation available, or even
> > > data which teams perform better or worse? Is there any differentiation
> > > between "internal" patches by team members vs. contributed patches?
> > > Or is this out of scope for TPG?

-- 
Andre Klapper | Wikimedia Bugwrangler
http://blogs.gnome.org/aklapper/