[QA] [Cloud-admin] [Ops] Delete button on gerrit

Mon Mar 5 20:30:07 UTC 2018

Wow, sounds like someone has been stuffing beans
<https://en.wikipedia.org/wiki/WP:DEVBEANS> up the Gerrit developers' noses
<https://en.wikipedia.org/wiki/WP:BEANS>.

On 5 March 2018 at 20:22, Ian Marlier <imarlier at wikimedia.org> wrote:

> If you happen to have an adblocker installed, you can add the delete
> button to the blocked elements list until it's addressed globally.
>
> On Mon, Mar 5, 2018 at 3:12 PM, Chase Pettet <cpettet at wikimedia.org>
> wrote:
>
>> It seems potentially the only time to use it would be an accidental leak
>> of sensitive info in a changeset, and you would still want to change the
>> leaked value. More than once I have discovered an abandoned change from
>> someone and learned a lesson so that seems like the superior everyday
>> mechanism for "not useful" anymore :)
>>
>> On Mar 5, 2018 2:00 PM, "Jaime Crespo" <jcrespo at wikimedia.org> wrote:
>>
>>> I just been told there is now a delete button, DON'T USE IT- I just
>>> pressed it by mistake after entering in edit mode thinking it was a
>>> "discard patch started on web interface" (but it is very easy to pres it by
>>> mistake), and apparently it removes the entire CR. I was told by Paladox
>>> this is a new feature on gerrit, and I do not like it already. I managed to
>>> delete the work of a workmate. :-(
>>>
>>> I could restore everthing from the database backups, but as it also
>>> deletes the git files content, it doesn't work without it -it cannot be
>>> reverted- only text can be recover from the database in not the nicest
>>> formatting.
>>>
>>> Apologies for the damages caused. Should I file a ticket to propose to
>>> disable such a button from the UI?
>>>
>>> --
>>> Jaime Crespo
>>> <http://wikimedia.org>
>>>
>>> _______________________________________________
>>> Cloud-admin mailing list
>>> Cloud-admin at lists.wikimedia.org
>>> https://lists.wikimedia.org/mailman/listinfo/cloud-admin
>>>
>>>
>> _______________________________________________
>> Ops mailing list
>> Ops at lists.wikimedia.org
>> https://lists.wikimedia.org/mailman/listinfo/ops
>>
>>
>
> _______________________________________________
> Cloud-admin mailing list
> Cloud-admin at lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/cloud-admin
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.wikimedia.org/pipermail/qa/attachments/20180305/01ddf2fb/attachment-0001.html>