[Labs-l] [NEW] Self-service git repository creation for tools

Sun Aug 28 14:21:31 UTC 2016

I have more concerns about Phabricator and I am going to follow Ladgroup's
suit and express them here, but feel free to redirect me:

1) With recent changes, Phabricator now uses Diffusion over Gerrit. Even
though Diffusion is presumably just "mirroring" Gerrit for most projects,
still when you go to a project's page the cloning URI you get is a
Diffusion URI. If I clone using that and submit a patch, it won't go to
Gerrit. That means the patch won't be reviewed. This is bad practice.

2) When I go to a project's page (e.g.
https://phabricator.wikimedia.org/project/view/203/ ), it does not provide
a link to its Diffusion page (e.g.
https://phabricator.wikimedia.org/diffusion/ECHU/ ). Finding a project's
source needs several clicks. (Is it the same complaint Ladsgroup  made?)

3) The SSH clone URI always starts with vcs at git-ssh ...; unless I totally
don't get how it work with Diffusion, I expect the git SSH URIs to start
with one's username (in my case huji at git-ssh ..., just like the case with
Gerrit where we use something like *ssh*://<USERNAME>@
gerrit.wikimedia.org:29418/*mediawiki*/ ). I would expect that when I am
logged in to Phabricator, it also shows me a clone URI that already
contains my username.

Overall, I like Phabricator over Gerrit (it is unified, has better UI,
etc.) but I am at a point (again!) where I feel like the core developers
who do this for a living are changing things around without paying
attention to usability and documentation to the point that occasional
developers like me could also quickly contribute.

</venting off>

Huji

On Sat, Aug 27, 2016 at 9:00 PM, Bryan Davis <bd808 at wikimedia.org> wrote:

> On Sat, Aug 27, 2016 at 4:40 PM, Bryan Davis <bd808 at wikimedia.org> wrote:
> > On Sat, Aug 27, 2016 at 1:50 PM, Magnus Manske
> > <magnusmanske at googlemail.com> wrote:
> >> Should existing, third-party repos be tracked in toolsadmin and/or
> Phabricator/Differential?
> >
> > I have (undocumented) plans to add support for editing and publishing
> > toolinfo.json compatible descriptions for each tool. When this is
> > implemented it will support connecting 3rd party hosting to each tool.
> >
> > Right now it is possible to create a Diffusion repo through the admin
> > console and then manually set it up as a mirror of an existing GitHub
> > repo through the management interface in Phabricator. Kunal managed to
> > do this with one of his tools [R1947]. Currently the configuration of
> > Phabricator itself only allows connecting to GitHub, but we have one
> > bug open to allow another external host. I expect as we talk through
> > the reasonable solutions of that issue that we will either open up to
> > a slightly larger fixed whitelist and come up with a procedure for
> > adding more, or determine that automatic external mirroring is
> > undesirable. If the answer ends up being that Wikimedia can't allow
> > their main Phabricator to connect to arbitrary 3rd party hosts to
> > mirror into Diffusion, I think someone can whip up a tool that can
> > poll, fetch and push to manage mirrors for interested tools in a
> > weekend. :)
>
> Related to this, if anyone has a Tool with an existing repository that
> is hosted in Diffusion (either directly or mirrored from Gerrit), feel
> free to open a ticket in the #Striker project asking to have it
> connected with your tool. I can manually alter the permissions on the
> Phabricator side to match what the admin console would do for a new
> repo and register it with the application's tracking database. I
> thought about making some UI for this in the app itself, but decided
> that the number of affected users was small enough that I could just
> handle it directly instead of introducing clutter.
>
> h/t to Luke081515 for bringing this topic up on irc to prompt this addendum
>
> Bryan
> --
> Bryan Davis              Wikimedia Foundation    <bd808 at wikimedia.org>
> [[m:User:BDavis_(WMF)]]  Sr Software Engineer            Boise, ID USA
> irc: bd808                                        v:415.839.6885 x6855
>
> _______________________________________________
> Labs-l mailing list
> Labs-l at lists.wikimedia.org
> https://lists.wikimedia.org/mailman/listinfo/labs-l
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.wikimedia.org/pipermail/labs-l/attachments/20160828/408c0fba/attachment.html>