[HipHop] Porting wikidiff2 to hhvm

Fri Mar 7 21:37:42 UTC 2014

Max,

Can you point me to the code sample where you a String is growing
indefinitely? Is it PHP code, or is it extension code? What specific API
is being used to grow the string?

Obviously we want to protect programmers from shooting themselves in the
foot, but at the same time we don't want to have unreasonably low limits
that prevent programmers from working with large strings. Having more
context would help with figuring out what the right course of action is.

-Drew

On 3/7/14 10:39 AM, "Max Semenik" <maxsem.wiki at gmail.com> wrote:

>Hey, I took a stab at making wikidiff2 a HHVM extension: [1]
>Seems to work fine, however I wonder if there is really no memory
>pools available in HHVM that would allow to mitigate possible leaks
>or sandbox consumption?  Iif you simply grow HPHP::String infinitely
>it will eat whole swap before segfaulting, which seems like a
>regression if compared to PHP.
>
>----
>[1] 
>https://urldefense.proofpoint.com/v1/url?u=https://gerrit.wikimedia.org/r/
>117362&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=9nYdTugriGWsUqKUk16gUxZeTAEwp5A
>D6due5Sf%2F0xw%3D%0A&m=pnEDtki4vMTyA9Quj%2FjX2tK5kYLbia%2FUZPK5fBoA3%2BM%3
>D%0A&s=56fc1e72faf1beb0b17313e5314b7b0f0487f79e48aa96f2d919ed17a00624a4
>
>-- 
>Best regards,
>  Max Semenik ([[User:MaxSem]])
>
>
>_______________________________________________
>HipHop mailing list
>HipHop at lists.wikimedia.org
>https://urldefense.proofpoint.com/v1/url?u=https://lists.wikimedia.org/mai
>lman/listinfo/hiphop&k=ZVNjlDMF0FElm4dQtryO4A%3D%3D%0A&r=9nYdTugriGWsUqKUk
>16gUxZeTAEwp5AD6due5Sf%2F0xw%3D%0A&m=pnEDtki4vMTyA9Quj%2FjX2tK5kYLbia%2FUZ
>PK5fBoA3%2BM%3D%0A&s=fde90d344ff9e8828631873e155d80192077e35a5961e30de8574
>f7593dfd9e5