New subject: CI build of empty patch fails in Vector repo in 'mediawiki/phan-taint-check-plugin'

1 Jun 2020

This has been happening since Saturday. Looking for resolution.

Empty patch to demonstrate:
https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/600431

Last merged patch (passed test, insignificant change to php):
https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/+/596512

Failure:
https://integration.wikimedia.org/ci/job/mwskin-php72-phan-seccheck-docker/…

Error:

TypeError: Argument 1 passed to
PreTaintednessVisitor::linkParamAndFunc() must be an instance of
Phan\Language\Element\Variable, instance of
Phan\Language\Element\Property given, called in
/opt/phan/vendor/mediawiki/phan-taint-check-plugin/src/PreTaintednessVisitor.php
on line 147 and defined in
/opt/phan/vendor/mediawiki/phan-taint-check-plugin/src/TaintednessBaseVisitor.php:1093Stack
trace:#0
/opt/phan/vendor/mediawiki/phan-taint-check-plugin/src/PreTaintednessVisitor.php(147):
PreTaintednessVisitor->linkParamAndFunc(Object(Phan\Language\Element\Property),
Object(Phan\Language\Element\Method), 0)#1
/opt/phan/vendor/mediawiki/phan-taint-check-plugin/src/MWPreVisitor.php(40):
PreTaintednessVisitor->visitMethod(Object(ast\Node))

...

Aron