Luke081515 set up #wikimedia-codereview on freenode and I'm going to try to
figure out some time slots that might work. I think we should start with
once or twice a week and expand from there.
Further input is welcome either here or on the task:
On Thu, Mar 31, 2016 at 3:33 PM, Greg Grossmeier <greg(a)wikimedia.org> wrote:
Forwarding to engineering@ to get more visibility from
WMF engineers who
have +2 and/or who want to experiment with a possible way of doing
code-review office hours.
There's a vote on the task to show your interest if you have it:
https://phabricator.wikimedia.org/T128371
Greg
----- Forwarded message from Greg Grossmeier <greg(a)wikimedia.org> -----
Date: Tue, 29 Mar 2016 14:22:03 -0700
From: Greg Grossmeier <greg(a)wikimedia.org>
To: Wikimedia developers <wikitech-l(a)lists.wikimedia.org>
Subject: [Wikitech-l] Code review office hours (was Re: Improving
Wikimedia's
Code Review process)
Reply-To: Wikimedia developers
<wikitech-l(a)lists.wikimedia.org>
Changing subject to focus on the code-review office hours idea.
Also, a request at the end for people with +2 to indicate if they would
be willing to participate in an experiment or not :)
<quote name="Jon Robson" date="2016-03-16" time="15:47:49
-0700">
> We have two swat windows every day. It's magical... I post a request
for
a
deploy on
a Wiki page and someone deploys it.
:) glad you like it
> Could we try a similar thing with code review. Code review window
(maximum
> 1 patch per person) and have a group of
+2ers look at a maximum set of
> patches?
>
> It would need a few more rules than that and a bit of tweaking but
seems
like a
good experiment. I'd sign up to help it if it was a maximum 2
windows for me a week.
That sounds like an interesting idea indeed, Jon.
An action item from me from the DevSummit was
https://phabricator.wikimedia.org/T128371, which is basically "setup
code-review office hours" without much more detail than that (it was a
drive-by idea during one of the sessions that I volunteered to follow-up
with).
My initial idea was very minimal (basically just a time and a virtual
place to do code-review together) but adding in the explicit support of
+2ers helping merge ready patches during the time gives it more
effectiveness.
The hardest part will, I assume, be getting enough people with commit
rights to volunteer for at least one day/week.
Any one reading this far with +2 willing to? If so, please comment on
the task (to save the mailing list):
https://phabricator.wikimedia.org/T128371
Thanks,
Greg
--
| Greg Grossmeier GPG: B2FA 27B1 F7EB D327 6B8E |
| identi.ca: @greg A18D 1138 8E47 FAC8 1C7D |
_______________________________________________
Wikitech-l mailing list
Wikitech-l(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikitech-l
----- End forwarded message -----
--
| Greg Grossmeier GPG: B2FA 27B1 F7EB D327 6B8E |
| identi.ca: @greg A18D 1138 8E47 FAC8 1C7D |
_______________________________________________
Engineering mailing list
Engineering(a)lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/engineering