Ævar Arnfjörð Bjarmason (avarab(a)gmail.com) [050617 07:25]: If you put it there, then search bugs will never get reported to the right component - when you do a search, there's no indication that you're using an extension, not MediaWiki core itself. So when you refactor components, be sure to remember how reporters will see things, not just the developers at the other end. - d.

Ævar Arnfjörð Bjarmason wrote: I was the one that put it in originally. I copied the concept from LiveJournal: someone attaches a patch and sets the 'patch' keyword; other developers search for bugs with the 'patch' but not 'reviewed' keyword; they look at the patches, test them, make sure they work, make sure the code is clean and everything, and add the 'reviewed' keyword. Developers with CVS access look for 'patch'+'reviewed', commit the patches and set the bug to RESOLVED FIXED. I know I don't have much say in this anymore because I'm not as active as I used to be, but I would nevertheless prefer if the 'patch' keyword would stay (and MediaZillians would set it appropriately). There is no way to search for patches otherwise (see below). This matches bugs that have an obsolete patch as well as a non-obsolete non-patch attachment. Besides, even if this would work, it is far too complex (UI-wise). Just because it can be done doesn't mean we can't add a quick keyword to make it easier. :) Also, in rare cases the 'patch' keyword might be set even if there is no patch: maybe the bug is about changing a CSS file or image file or something and the attachment is just the new file. Thanks for listening, Timwi