Getting Phan voting is a great first step, but we need everyone's help to improve the strictness of analysis we apply. For this initial rollout Phan is only voting on critical errors. These are typically PHP fatal errors like referencing a class that doesn't exist (missing use statement?) and calling methods that don't exist (fat fingers? Incomplete refactor?). I'll soon have merged a change that reduces the minimum error level from critical to low, and adds a blacklist of all issue types that currently exist. Please take a look at tests/phan/config.php and choose a type to fix. There is a comment with each item that says how many exist. Remove the item from the blacklist, fix the issues, and get it merged to strengthen the analysis we apply to all patches. I should also note that Phan isn't trying to guarantee that code is correct. It is trying to find code that is most likely to be incorrect. There are occasionally false positives but that's life. A patch implementing per line issue suppression is being worked on to address these. On Dec 12, 2016 11:24 PM, "Legoktm" <legoktm.wikipedia(a)gmail.com> wrote: