Wikitech-l July 2019

wikitech-l@lists.wikimedia.org

54 participants
65 discussions

Dealing with composer dependencies in early MediaWiki initialization

by Kunal Mehta

-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA512 Hi, I (with Reedy's help) recently started work on librarizing MediaWiki's IP class into a separate composer package (wikimedia/ip-utils[1]). The main motivation was so that the Parsoid PHP port could use it[2]. However, I ran into an unexpected hitch[3], as it seems we're using the IP class before the composer autoloader is even intialized. Here's the basic initialization in Setup.php: - - AutoLoader.php (MediaWiki's) - - Defines.php - - DefaultSettings.php - $wgServer = WebRequest::detectServer() - Calls IP::splitHostAndPort() - - GlobalFunctions.php - - vendor/autoload.php (composer's) My understanding is that composer's autoloader runs late so extensions registering themselves using it can add their stuff to the necessary globals. And we call WebRequest::detectServer() in DefaultSettings.php so that in LocalSettings.php people can use the value of $wgServer for other stuff. I see 3 main ways to move forward: 1. Move vendor/autoload.php earlier in Setup.php, potentially breaking extensions that still rely on composer autoloading for initialization. 2. Set $wgServer = false or something in DefaultSettings.php, and then fill it in later in Setup.php *after* the composer autoloader has been loaded, potentially breaking anyone relying on the value of $wgServer in LocalSettings.php. 3. (status quo) not librarize code that runs before composer autoloader initialization. :( Advice/input welcome. [1] https://packagist.org/packages/wikimedia/ip-utils [2] https://gerrit.wikimedia.org/g/mediawiki/services/parsoid/+/77064cfff717 6493a2828bb4f95f397dfce7d659/src/Utils/Title.php#46 [3] https://gerrit.wikimedia.org/r/c/mediawiki/core/+/519089/ - -- Legoktm -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE2MtZ8F27ngU4xIGd8QX4EBsFJpsFAl0S1oQACgkQ8QX4EBsF Jpufrg/+J9RUUxRAtgJLEkyACE6GREis0eyEIZnWmMr3s9YpFPoqtWocFrUk6Wsn W7d9Oda/8CW0/d894gGMn8LWIj9oWq2gMPWzCVFpg8uu3r4967qxBp+ba29uMOJw Qpw6DhXtPvVAeUCy8P38Y5vM7TGmV+J1T5jDY21zimT1dRrJsI1KD+u/Ue3nYy/y B1ic3i7vJfhYErdhHgN98ETXfXOaDx4rgd2N7PLjVNx3IYCC8LNiR8wSLuydfdbk PLTT1bA2qi0h2wgcEr7Qtq9YstVotq8899rgKLtGDBwQi3qGNcdOgQGEMFDVfjfO CsiWocj6s4oc3ScVj+Eb9xtvIqhNx+oRbWE1vKd4TmtSdyzpv6xadV60tq5qNFEY I0cBDOWU5UFNHbvbyjK4dqIDEVhJ6LiEgLVBOj81U27s8mR4Dv/yFB3eac0ROk7p gaEeOjfhtVU558XfpEsmu1H05VJT3kXNxK8y0UQOjy11SErzsXv6vDzyzLDJM/W7 WF0I4nyjeqVsBjLBN9li+5AnU3cAKVOCfZ+/aRYyg89Du//nJRjm+4lxnuPrGlaG ES/nVUnkDZ9Yc/xA1yacm3Ytx9hpoY1mIZgxxxveyeU1KsNXAZ2BOGA2T7kU4yUw Uyg+byYwI+1uVOjAVd3BInGV2R2/GmeIn9FOpthBaw8wcz0Y/8c= =tU4+ -----END PGP SIGNATURE-----

4 years, 9 months

Train

by RhinosF1 Wikipedia

Hi, Am I mistaken that based on https://phabricator.wikimedia.org/T220739 the train should be fully rolled back? https://noc.wikimedia.org/conf/highlight.php?file=wikiversions.json seems to show otherwise. RhinosF1

4 years, 9 months

Fwd: [RelEng] deployment-prep outage this Friday

by Tyler Cipriani

The beta cluster will be intermittently unavailable tomorrow due to WMCS maintenance. See forwarded message for details. Thanks! -- Tyler ----- Forwarded message from Andrew Bogott <abogott(a)wikimedia.org> ----- >Date: Wed, 17 Jul 2019 15:51:57 -0500 >From: Andrew Bogott <abogott(a)wikimedia.org> >To: Release Engineering <releng(a)lists.wikimedia.org> >Subject: [RelEng] deployment-prep outage this Friday > > On Friday I'm going to move many of the VMs in deployment-prep to new > hardware. The effect of this will be rolling, intermittent outages > throughout the project as different pieces are offline. > > I'll be starting in my morning, around 14:00 UTC (7AM Pacific Time). The > total process will take several hours. > > > -Andrew > > > _______________________________________________ > RelEng mailing list > RelEng(a)lists.wikimedia.org > https://lists.wikimedia.org/mailman/listinfo/releng ----- End forwarded message -----

4 years, 9 months

Scrum of scrums/2019-07-17

by Željko Filipin

Hi, for HTML version see https://www.mediawiki.org/wiki/Scrum_of_scrums/2019-07-17 Željko -- = 2019-07-17 = == Callouts == * Site Reliability Engineering - DBAs say: Wikidata master database switchover scheduled for 30th July 05:00-05:30 AM UTC (requires read-only) https://phabricator.wikimedia.org/T227062 * Search Platform blocked by Release Engineering: WDQS GUI build is broken: https://phabricator.wikimedia.org/T227818 * Release Engineering - train blocked ** Search Platform - T228283 ElasticaErrorHandler.php: Object of class Elastica\Response could not be converted to string ** Core Platform - T228286 LocalFile.php: Call to a member function getName() on a non-object (null) * Language blocked by Core Platform: T228025 - Translate sandbox signup is broken == Product == === Contributors === ==== Editing ==== * Updates: ** Improved performance of section editing by only building the CE tree for the selected section: https://phabricator.wikimedia.org/T215717#5330186 ** Iterating on edit cards ** Removed "Welcome to Wikipedia" overlay on mobile VE: https://phabricator.wikimedia.org/T227670 ==== Growth ==== * Blocking: ** Scoring Platform - Working with Growth on triaging ORES filter updates https://phabricator.wikimedia.org/T227094 * Updates: ** Homepage: Use 2x2 grid for mobile summary of start module (task T227109) ** Allow posting questions to Flow pages (task T212433) ** Do not let users thank for a log entry if actor was deleted (task T224240) === Readers === ==== iOS native app ==== * Updates: **Released 6.3 https://phabricator.wikimedia.org/tag/ios-app-v6.3-lobster-on-a-motorcycle/ ***talk pages ***bug fixes *** media & link insertion editing tools **Working on 6.3.1 https://phabricator.wikimedia.org/tag/ios-app-v6.3.1_lobster-on-an-orv/ *** bug fixes *** talk pages enhancements ==== Android native app ==== * Updates: ** Released to Beta! (structured image caption editing / suggested edits for image captions and article descriptions) ** Working on integrating with page mobile-html endpoint. Current board: https://phabricator.wikimedia.org/project/view/4123/ ==== Readers Web ==== * Updates: ** Summary: continuing development of the advanced mobile contributions and MobileFrontend architecture projects. ** Responsive website (MinervaNeue / MobileFrontend / Portals): *** [ https://www.mediawiki.org/wiki/Reading/Web/Advanced_mobile_contributions Advanced mobile contributions] **** [https://phabricator.wikimedia.org/T225731 <nowiki>AMC - mark AMC setting as "new" </nowiki>] **** [https://phabricator.wikimedia.org/T220016 <nowiki>Create new MobileWebUIActionsTracking schema</nowiki>] **** [https://phabricator.wikimedia.org/T214540 <nowiki>[EPIC] AMC Navigation - user menu</nowiki>] **** [https://phabricator.wikimedia.org/T224735 <nowiki>[AMC] Updates to user pages</nowiki>] **** [https://phabricator.wikimedia.org/T224070 <nowiki>Update notifications & search icons (AMC & non-AMC)</nowiki>] **** [https://phabricator.wikimedia.org/T195795 <nowiki>Use a clearly intended height on MinervaNeue header</nowiki>] *** [ https://www.mediawiki.org/wiki/Reading/Web/Projects/Invest_in_the_MobileFro… Invest in the MobileFrontend & MinervaNeue frontend architecture] **** [https://phabricator.wikimedia.org/T225447 Tasking] **** [https://phabricator.wikimedia.org/T217102 <nowiki>MFA: TalkSectionAddOverlay should use Overlay.make pattern</nowiki>] **** [https://phabricator.wikimedia.org/T193077 <nowiki>Remove Page's View functionality</nowiki>] **** [https://phabricator.wikimedia.org/T123328 <nowiki>[GOAL] Lazy load references in mobile skin</nowiki>] **** [https://phabricator.wikimedia.org/T212944 <nowiki>Update page issues folder structure</nowiki>] *** Miscellaneous: **** [https://phabricator.wikimedia.org/T227929 <nowiki>CSS spiked by 2kb (23% increase) for ALL users</nowiki>] **** [https://phabricator.wikimedia.org/T228235 <nowiki>Edits lost when clicking back from talk overlay</nowiki>] **** [https://phabricator.wikimedia.org/T225423 <nowiki>Minerva - Special:ContentTranslation displays TypeError:"options is null"</nowiki>] **** [https://phabricator.wikimedia.org/T226106 <nowiki>[Research 4hrs] Three clicks required to exit talk overlay</nowiki>] **** [https://phabricator.wikimedia.org/T225100 <nowiki>"Minerva AB test" blocking merge in unrelated repos</nowiki>] **** [https://phabricator.wikimedia.org/T201131 <nowiki>Bug: Order of some paragraphs is flipped on mobile</nowiki>] **** [https://phabricator.wikimedia.org/T97891 <nowiki>setPageTitle to empty string or false should prevent rendering of H1 on page otherwise Wikivoyage will print 2 h1 elements in Vector</nowiki>] **** [https://phabricator.wikimedia.org/T225260 <nowiki>BUG: Notifications tray (mobile) - margins and borders</nowiki>] **** [https://phabricator.wikimedia.org/T220979 <nowiki>[Bug] Notification counts broken on mobile</nowiki>] **** [https://phabricator.wikimedia.org/T220668 <nowiki>Regression: Download icon doesn't download images</nowiki>] ** Planning *** Desktop refresh planning ==== Product Infrastructure ==== * Updates: ** Will only answer to "Product Infrastructure" from now on ** Released a new pagelib version with a fix for the interaction handling of reference clicks and missing interaction handling of pronunciation clicks. ** Investigating OSM corruption https://phabricator.wikimedia.org/T218097 ** Followup to ReadingLists incident: https://phabricator.wikimedia.org/T227665 ** Planned Modern Event Platform Stream Configuration Service architecture: https://phabricator.wikimedia.org/T205319 ** Event Platform Client Library specification process ongoing: https://phabricator.wikimedia.org/T228175 ** Updating open_nsfw project for deployment in WMF prod (as nsfwoid): https://github.com/mdholloway/nsfwoid ==== Structured Data ==== * Updates: ** We are now called the structured data team :o ** working on getting arbitrary statements for files on commons production-ready === Language === * Blocked by: ** Core Platform: T228025 - Translate sandbox signup is broken === UI Standardization === * Updates: ** OOUI v0.33.3 released https://phabricator.wikimedia.org/diffusion/GOJU/browse/master/History.md *** WindowManager: Prevent iOS Safari from scrolling the page behind the dialog *** ProcessDialog aftermath styling from 0.33.0 overhaul ** Continuing work on Special:Contributions related to AMC https://phabricator.wikimedia.org/T117736 == Technology == === Fundraising Tech === * Updates: ** Waiting on payment processor to test India forms ** Finishing backend work for recurring donation conversion ** updating CiviCRM custom fields for our users ** Fixing CentralNotice bugs having to do with EventLogging updates ** Making a couple of our message queue consumers more parallelizable ** Almost done converting all our python2 tools to python3 === Core Platform === * Blocking: ** Release Engineering: *** MediaWiki installer silently ignores invalid extensions https://phabricator.wikimedia.org/T225512 *** T228286 LocalFile.php: Call to a member function getName() on a non-object (null) ** Language: T228025 - Translate sandbox signup is broken ** Performance: Need CR for <nowiki>{{PAGEID}}</nowiki> optimization. – https://gerrit.wikimedia.org/r/519352 * Updates: ** Transition planning this week === Engineering Productivity === ==== Performance ==== * Blocked by: ** Core Platform: Need CR for {{PAGEID}} optimization. – https://gerrit.wikimedia.org/r/519352 ** WMDE/Wikidata: Need help figuring out why DeferredUpdates enqueue-on-failure patch is incompatible with Wikibase. – https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/497537/ ** Site Reliability Engineering: Need review on the filter logic of obsolete domains in GTIDs for GTID_WAIT. – https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/517830/ * Updates: ** Peter and Gilles of our team will be attending WeLoveSpeed! – https://www.welovespeed.com/2019/programme/ ** Aaron is helping CPT with identifying and migrating (some) users of MainStash. (Thanks! -CPT) ** Q Goals published at https://www.mediawiki.org/wiki/Wikimedia_Technology/Goals/2019-20_Q1#Perfor… ==== Release Engineering ==== * Blocked by: ** Core Platform: MediaWiki installer silently ignores invalid extensions https://phabricator.wikimedia.org/T225512 * Blocking: ** Search Platform: WDQS GUI build is broken: https://phabricator.wikimedia.org/T227818 * Updates: ** Train Health *** Last week: 1.34.0-wmf.13 - https://phabricator.wikimedia.org/T220738 *** This week: 1.34.0-wmf.14 - https://phabricator.wikimedia.org/T220739 **** Search Platform - T228283 ElasticaErrorHandler.php: Object of class Elastica\Response could not be converted to string **** Core Platform - T228286 LocalFile.php: Call to a member function getName() on a non-object (null) *** Next week: 1.34.0-wmf.15 - https://phabricator.wikimedia.org/T220740 === Scoring Platform === * Blocked by: ** Working with Growth on triaging ORES filter updates https://phabricator.wikimedia.org/T227094 * Updates: ** Jade RFC finally closed! https://phabricator.wikimedia.org/T200297 ** Andy Craze working on ORES deployment and Jade development -- working API incoming ** Working with Core platform on Jade-related schema changes === Search Platform === * Blocked by: ** Release Engineering: WDQS GUI build is broken: https://phabricator.wikimedia.org/T227818 * Blocking: ** Release Engineering - T228283 ElasticaErrorHandler.php: Object of class Elastica\Response could not be converted to string * Updates: ** Reindexing WDQS servers: https://phabricator.wikimedia.org/T228122 ** Troubles reindexing wikidata: https://phabricator.wikimedia.org/T227136 ** Working on creating RDF export for SDC/MediaInfo: https://phabricator.wikimedia.org/T221917 ** Working on getting glent suggestions into Elastic indexes: https://phabricator.wikimedia.org/T227364 ** Working on CirrusSearch configuration for cloudelastic: https://phabricator.wikimedia.org/T220625 ** Working on CirrusSearch query dispatcher: https://phabricator.wikimedia.org/T216429 === Security === * Updates: ** Received: Security review of preact 8.4.2, to be assigned: https://phabricator.wikimedia.org/T227726 ** Received & Assigned: (informal) Security Concept Review For LibUp 2.0, starting: https://phabricator.wikimedia.org/T227820 ** Received & Assigned: Concept Review for the machine vision, new, starting - https://phabricator.wikimedia.org/T227591 ** Froze: Waiting on update from Yurik/Vega folks (upstream) to proceed stalled - https://phabricator.wikimedia.org/T222806 === Site Reliability Engineering === * Blocking: ** Performance: Need review on the filter logic of obsolete domains in GTIDs for GTID_WAIT. – https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/517830/ * Updates: ** DBAs say: Wikidata master database switchover scheduled for 30th July 05:00-05:30 AM UTC (requires read-only) https://phabricator.wikimedia.org/T227062 == Wikimedia DE == === Wikidata === * Blocking: ** Performance: Need help figuring out why DeferredUpdates enqueue-on-failure patch is incompatible with Wikibase. – https://gerrit.wikimedia.org/r/#/c/mediawiki/core/+/497537/ == SoS Meeting Bookkeeping == * Updates: ** Jazmin and/or Deb will facilitate the meeting for the next three weeks

4 years, 9 months

1.34.0-wmf.14 status update

by Lars Wirzenius

The 1.34.0-wmf.14 version of MediaWiki is blocked[0]. The new version is deployed to {group0}[1], but can proceed no further until these issues are resolved: * TopicListBlock.php sort order params - <https://phabricator.wikimedia.org/T228406> * RevisionFormatter.php: Unknown content format - <https://phabricator.wikimedia.org/T228417> Once these issues are resolved train can resume. If these issues are resolved on a Friday the train will resume Monday. Thank you for your help resolving these issues! -- Your humble train toiler [0]. <https://phabricator.wikimedia.org/T220739> [1]. <https://tools.wmflabs.org/versions/>

4 years, 9 months

Discovery Weekly Update for the week starting 2019-06-24

by Chris Koerner

Hello, This is the weekly update from the Search Platform team for the week starting 2019-06-24. As always, feedback and questions are welcome. == Discussions == === Search === * We needed a few alerts to happen when / if mjolnir starts misbehaving [0] * Mathew created an Icinga plugin to check number of eligible masters [1] * Mathew also created a WDQS reboot cookbook [2] * The team worked on implementing a match for any-language label (haslabel:*) [3] * We were getting errors because MediaWiki-Vagrant: ES_PATH_CONF must be set to the configuration path [4], thanks Tgr for the fix! * There was a PHP error from CirrusSearch/RequestLogger: "Array to string conversion" that David fixed [5] * There was an error where ascii folding behaved differently for autocomplete vs. search that David worked on [6] * David worked on another PHP warning where: Invalid argument supplied for foreach() [7] * Gehel and the team did some capacity planning: for Elastic via replaying prod traffic at a higher velocity at our dallas DC, findings to inform our hardware asks and to be documented in wikitech [8] === Wikidata query service === * Stas added capability to include wildcards into federation whitelist [9]. This allows adding endpoints (such as DBPedia) which require various URL parameters. * Stas added ability to use variable as endpoint for MWAPI service [10] * Stas added federated query metrics to WDQS [11] * Stas finished upgrade of Blazegraph to Sesame 2.8 [12] * Stas fixed JSON output format breakage due to upgrade above [13] * Stas fixed some bad strings in WDQS data that confused Blazegraph [14] [0] https://phabricator.wikimedia.org/T214494 [1] https://phabricator.wikimedia.org/T224073 [2] https://phabricator.wikimedia.org/T224385 [3] https://phabricator.wikimedia.org/T224611 [4] https://phabricator.wikimedia.org/T224791 [5] [https://phabricator.wikimedia.org/T226568 [6] https://phabricator.wikimedia.org/T226241 [7] https://phabricator.wikimedia.org/T226969 [8] https://phabricator.wikimedia.org/T221121 [9] https://phabricator.wikimedia.org/T196858 [10] https://phabricator.wikimedia.org/T171303 [11] https://phabricator.wikimedia.org/T194101 [12] https://phabricator.wikimedia.org/T200612 [13] https://phabricator.wikimedia.org/T225996 [14] https://phabricator.wikimedia.org/T225523 ---- Subscribe to receive on-wiki (or opt-in email) notifications of the Discovery weekly update. https://www.mediawiki.org/wiki/Newsletter:Discovery_Weekly The archive of all past updates can be found on MediaWiki.org: https://www.mediawiki.org/wiki/Discovery/Status_updates Interested in getting involved? See tasks marked as "Easy" or "Volunteer needed" in Phabricator. [1] https://phabricator.wikimedia.org/maniphest/query/qW51XhCCd8.7/#R [2] https://phabricator.wikimedia.org/maniphest/query/5KEPuEJh9TPS/#R Yours, Chris Koerner (he/him) Community Relations Specialist Wikimedia Foundation

4 years, 9 months

Changes and improvements to PHPUnit testing in MediaWiki

by Kosta Harlan

Hi all, Please have a look at https://phabricator.wikimedia.org/phame/post/view/169/changes_and_improveme… <https://phabricator.wikimedia.org/phame/post/view/169/changes_and_improveme…> regarding some significant changes and improvements to the PHP testing tools included with MediaWiki. Your feedback and contributions are most welcome, either here, on phab, or on IRC (Amir1 and kostajh in #wikimedia-codehealth). One of us should be around during the technical advice IRC meeting tomorrow as well if you have questions about how to port your tests, run Amir’s script, or have suggestions / feedback. Sincerely, Kosta & Amir

4 years, 9 months

Wednesday: Technical Advice IRC Meeting

by Raz Shuty

Sorry for cross-posting! Reminder: Technical Advice IRC meeting this week **Wednesday 3-4 pm UTC** on #wikimedia-tech. Questions can be asked in English and German! The Technical Advice IRC Meeting (TAIM) is a weekly support event for volunteer developers. Every Wednesday, two full-time developers are available to help you with all your questions about Mediawiki, gadgets, tools and more! This can be anything from "how to get started" over "who would be the best contact for X" to specific questions on your project. If you know already what you would like to discuss or ask, please add your topic to the next meeting: https://www.mediawiki.org/wiki/Technical_Advice_IRC_Meeting Hope to see you there! -- Raz Shuty Engineering Manager Wikimedia Deutschland e. V. | Tempelhofer Ufer 23-24 | 10963 Berlin Phone: +49 (0)30 219 158 26-0 https://wikimedia.de Imagine a world, in which every single human being can freely share in the sum of all knowledge. That‘s our commitment. Wikimedia Deutschland - Gesellschaft zur Förderung Freien Wissens e. V. Eingetragen im Vereinsregister des Amtsgerichts Berlin-Charlottenburg unter der Nummer 23855 B. Als gemeinnützig anerkannt durch das Finanzamt für Körperschaften I Berlin, Steuernummer 27/029/42207.

4 years, 9 months

Skipcaptcha assigned to users coming from throttle-exempted IP addresses

by Martin Urbanec

Hi, I created https://phabricator.wikimedia.org/T227487, which proposes to add skipcaptcha to all users coming from throttle-exempted IP addresses (see /wmf-config/throttle.php in operations/mediawiki-config for that). This can make some events go more smoothly. Given users coming from such addresses are generally trusted, this shouldn't be an issue IMHO. What do the others think? Martin

4 years, 9 months

TechCom Radar 2019-07-10

by Kate Chapman

Hi All, Here are the minutes from this week's TechCom meeting: * RFC approved: Introduce a new namespace for collaborative judgements about wiki entities <https://phabricator.wikimedia.org/T200297> * IRC meeting moved to July 17 in #wikimedia-office Abstract schemas and schema changes: <https://phabricator.wikimedia.org/T191231> (note new time/date: July 17 2019 14:00 UTC/16:00 CEST/06:00 PDT) * IRC meeting on Merge Extension:Theme into core <https://phabricator.wikimedia.org/T122924> in #wikimedia-office on July 24th at 21:00 UTC/23:00 CEST/14:00 PDT * Did not require a RFC: Core should provide inline diffs as well as side by side <https://phabricator.wikimedia.org/T117279> You can also find our meeting minutes at <https://www.mediawiki.org/wiki/Wikimedia_Technical_Committee/Minutes> See also the TechCom RFC board <https://phabricator.wikimedia.org/tag/mediawiki-rfcs/>. If you prefer you can subscribe to our newsletter here <https://www.mediawiki.org/wiki/Newsletter:TechCom_Radar> Thanks, Kate -- Kate Chapman Senior Program Manager, Core Platform Wikimedia Foundation kchapman(a)wikimedia.org

4 years, 9 months

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

2004

2003

2002

Wikitech-l July 2019