On 11/22/06, werdna(a)svn.wikimedia.org <werdna(a)svn.wikimedia.org> wrote:
> Revision: 17847
> Author: werdna
> Date: 2006-11-22 03:51:49 -0800 (Wed, 22 Nov 2006)
>
> Log Message:
> -----------
> * (bug 7883) Added autoblock whitelisting feature, using which specific ranges can be protected from autoblocking. These ranges are specified, in list format, in the autoblock_whitelist system message.
. . .
> function doAutoblock( $autoblockip ) {
. . .
> + $ip = wfGetIp();
. . .
> + # Is the IP in this range?
> + if (wfIsAddressInRange( $ip, $wlEntry )) {
Um, I'm pretty tired, but shouldn't you be checking against
$autoblockip, not wfGetIp()? The IP of the current request is going
to be the blocker, at least on retroactive autoblocks.
Hi,
It seems like it's possible to edit the software messages by going to
Special:Allmessages, clicking on a message, editing it and saving it.
Is there any easy way to generate a MessagesXX.php file from what's
the state of the message cache, so the messages can be moved between
versions, or times when the messages are rebuilt?
Travis
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
> Revision: 17852
> Author: midom
> Date: 2006-11-22 06:06:00 -0800 (Wed, 22 Nov 2006)
...
> remove 'subkey' (255) for a field which is 40-chars long, fixes stuff...
You sure about that? ipb_address can hold both IPs and usernames: the
latter of which is defined as varchar(255).
- --
Greg Sabino Mullane greg(a)turnstep.com
PGP Key: 0x14964AC8 200611221247
http://biglumber.com/x/web?pk=2529DF6AB8F79407E94445B4BC9B906714964AC8
-----BEGIN PGP SIGNATURE-----
iD8DBQFFZI2PvJuQZxSWSsgRAt1zAKDy7F1/dv/vQK11s5d8XfPVl6lxnACgzx7x
pK1zPMafApgvemI28kcmt68=
=N7ND
-----END PGP SIGNATURE-----
An automated run of parserTests.php showed the following failures:
Reading tests from "/home/brion/src/wiki/phase3/maintenance/parserTests.txt"...
Running test TODO: Table security: embedded pipes (http://mail.wikipedia.org/pipermail/wikitech-l/2006-April/034637.html)... FAILED!
Running test TODO: Link containing double-single-quotes '' (bug 4598)... FAILED!
Running test TODO: Template with thumb image (with link in description)... FAILED!
Running test TODO: message transform: <noinclude> in transcluded template (bug 4926)... FAILED!
Running test TODO: message transform: <onlyinclude> in transcluded template (bug 4926)... FAILED!
Running test BUG 1887, part 2: A <math> with a thumbnail- math enabled... FAILED!
Running test TODO: HTML bullet list, unclosed tags (bug 5497)... FAILED!
Running test TODO: HTML ordered list, unclosed tags (bug 5497)... FAILED!
Running test TODO: HTML nested bullet list, open tags (bug 5497)... FAILED!
Running test TODO: HTML nested ordered list, open tags (bug 5497)... FAILED!
Running test TODO: Parsing optional HTML elements (Bug 6171)... FAILED!
Running test TODO: Inline HTML vs wiki block nesting... FAILED!
Running test TODO: Mixing markup for italics and bold... FAILED!
Running test TODO: 5 quotes, code coverage +1 line... FAILED!
Running test TODO: dt/dd/dl test... FAILED!
Running test TODO: Images with the "|" character in the comment... FAILED!
Running test TODO: Parents of subpages, two levels up, without trailing slash or name.... FAILED!
Running test TODO: Parents of subpages, two levels up, with lots of extra trailing slashes.... FAILED!
Running test TODO: Don't fall for the self-closing div... FAILED!
Running test TODO: Always escape literal '>' in output, not just after '<'... FAILED!
Reading tests from "/home/brion/src/wiki/phase3/extensions/Cite/citeParserTests.txt"...
Passed 449 of 469 tests (95.74%)... FAILED!
MediaWiki 1.8.2 is not istalling for me.
I receive no php errors.
The install script reorts the following after I submit the form
MediaWiki 1.8.2 Installation
Don't forget security updates! Keep an eye on the low-traffic release
announcements mailing list.
Checking environment...
Please include all of the lines below when reporting installation problems.
PHP 5.1.6 installed
Found database drivers for: MySQL
PHP server API is apache2handler; ok, using pretty URLs
(index.php/Page_Title)
Have XML / Latin1-UTF-8 conversion support.
PHP is configured with no memory_limit.
Have zlib support; enabling output compression.
Couldn't find Turck MMCache, eAccelerator or APC. Object caching functions
cannot be used.
GNU diff3 not found.
Found GD graphics library built-in, image thumbnailing will be enabled if
you enable uploads.
Installation directory: C:\htdocs\wiki
Script URI path: /wiki
Environment checked. You can install MediaWiki.
Warning: $wgSecretKey key is insecure, generated with mt_rand(). Consider
changing it manually.
Generating configuration file...
Database type: MySQL
Loading class: DatabaseMysql
Attempting to connect to database server as root...success.
Connected to 5.0.26-community-nt
Database wikidb exists
Creating tables... using MySQL 4 table defs...Query "CREATE TABLE `user`
( user_id int(5) unsigned NOT NULL auto_increment, user_name varchar(255)
binary NOT NULL default '', user_real_name varchar(255) binary NOT NULL
default '', user_password tinyblob NOT NULL default '', user_newpassword
tinyblob NOT NULL default '', user_email tinytext NOT NULL default '',
user_options blob NOT NULL default '', user_touched char(14) binary NOT
NULL default '', user_token char(32) binary NOT NULL default '',
user_email_authenticated char(14) binary, user_email_token char(32)
binary, user_email_token_expires char(14) binary, user_registration
char(14) binary, PRIMARY KEY user_id (user_id), UNIQUE INDEX user_name
(user_name), INDEX (user_email_token) ) TYPE=InnoDB " failed with error
code "BLOB/TEXT column 'user_password' can't have a default value
(localhost)".
I think it may be my install of mysql, but I am not shure what to do if it
is.
My server is running the following
Windows XP
Apache/2.0.59 (Win32)
PHP/5.1.6
MySql version: 5.0.26-community-nt
Sorry, if this is the wrong newsgroup
On 11/22/06, Simetrical <Simetrical+wikitech(a)gmail.com> wrote:
> It's just that there's no edit count stored directly in the database
> at present (at least not that I can see in a quick glance at the
> schema). You have to do a count, which is O(N). An edit count could
> be added, presumably, if it were deemed useful, but I'm not the person
> to ask about whether that would slow things down or not, or otherwise
> be deemed undesirable.
Yeah. It would apparently have some use, if people keep making
requests for things which rely on it. Well, let's do this officially,
anyway:
Brion, may we please have an edit count field?
Steve
Good evening/morning
There's a discussion on the french speaking wikipedia about granted
some users the power to block vandals one day. Is that possible? I do
think right now it's not, but is it possible to create a new level
granted by bureaucrats that allows the user ONLY to use blocking for a
preset time? Those users wouldn't have access to delete and other
sysops abilities.
Before letting them going further into the organisation of this I
though it was better to have a technical answer about it.
Sorry to bother you
Have a nice day
--
schiste
Hello,
It has been floated a few times that new users should have to go
through a copyright or licensing quiz before uploading material to the
Commons. If there was widespread community support to implement such a
thing, would the developers be willing to code such a quiz into either
Special:Createaccount or Special:Upload (for first time uploaders)?
The type of quiz I mean is here:
http://commons.wikimedia.org/wiki/User:Pfctdayelise/Licensing_quiz
regards,
Brianna
user:pfctdayelise
An automated run of parserTests.php showed the following failures:
Reading tests from "/home/brion/src/wiki/phase3/maintenance/parserTests.txt"...
Running test TODO: Table security: embedded pipes (http://mail.wikipedia.org/pipermail/wikitech-l/2006-April/034637.html)... FAILED!
Running test TODO: Link containing double-single-quotes '' (bug 4598)... FAILED!
Running test TODO: Template with thumb image (with link in description)... FAILED!
Running test TODO: message transform: <noinclude> in transcluded template (bug 4926)... FAILED!
Running test TODO: message transform: <onlyinclude> in transcluded template (bug 4926)... FAILED!
Running test BUG 1887, part 2: A <math> with a thumbnail- math enabled... FAILED!
Running test TODO: HTML bullet list, unclosed tags (bug 5497)... FAILED!
Running test TODO: HTML ordered list, unclosed tags (bug 5497)... FAILED!
Running test TODO: HTML nested bullet list, open tags (bug 5497)... FAILED!
Running test TODO: HTML nested ordered list, open tags (bug 5497)... FAILED!
Running test TODO: Parsing optional HTML elements (Bug 6171)... FAILED!
Running test TODO: Inline HTML vs wiki block nesting... FAILED!
Running test TODO: Mixing markup for italics and bold... FAILED!
Running test TODO: 5 quotes, code coverage +1 line... FAILED!
Running test TODO: dt/dd/dl test... FAILED!
Running test TODO: Images with the "|" character in the comment... FAILED!
Running test TODO: Parents of subpages, two levels up, without trailing slash or name.... FAILED!
Running test TODO: Parents of subpages, two levels up, with lots of extra trailing slashes.... FAILED!
Running test TODO: Don't fall for the self-closing div... FAILED!
Running test TODO: Always escape literal '>' in output, not just after '<'... FAILED!
Reading tests from "/home/brion/src/wiki/phase3/extensions/Cite/citeParserTests.txt"...
Passed 449 of 469 tests (95.74%)... FAILED!
simetrical(a)svn.wikimedia.org wrote:
> + $templates = ($this->preview || $this->section) ? $this->mPreviewTemplates : $this->mArticle->getUsedTemplates();
> + $templates = $sk->formatTemplates( $templates, $this->preview, $this->section != '');
As a style note: I recommend against reusing a variable for two
different types of data like this. It's confusing when reading the code,
and can be maddening when splicing new code into the middle of an
existing function that does this.
There are a lot of examples of that in older code, unfortunately, but
that shouldn't be emulated. ;)
> - wfMsgExt( 'templatesused', array( 'parse' ) ) .
> + wfMsgExt( 'templatesused' . ( $preview ? 'preview' : ( $section ? 'section' : '' ) ), array( 'parse' ) ) .
I'm also not sure it's a great idea to build message key references
dynamically this way, when it's not really needed.
The way this code is, you won't be able to easily search for where the
messages "templatesusedpreview" and "templatesusedsection" get used in
the code. That can contribute to maintenance problems later; for
instance the messages might get removed on the belief they are no longer
being used.
-- brion vibber (brion @ pobox.com)