http://www.mediawiki.org/wiki/Special:Code/pywikipedia/10983 Revision: 10983 Author: xqt Date: 2013-01-25 13:10:38 +0000 (Fri, 25 Jan 2013) Log Message: ----------- use set for self.hiddentemplates to prevent exhausting memory usage Modified Paths: -------------- trunk/pywikipedia/checkimages.py Modified: trunk/pywikipedia/checkimages.py =================================================================== --- trunk/pywikipedia/checkimages.py 2013-01-25 12:11:39 UTC (rev 10982) +++ trunk/pywikipedia/checkimages.py 2013-01-25 13:10:38 UTC (rev 10983) @@ -574,8 +574,8 @@ self.com = pywikibot.translate(self.site, msg_comm10) hiddentemplatesRaw = pywikibot.translate(self.site, HiddenTemplate, fallback=False) - self.hiddentemplates = [pywikibot.Page(self.site, tmp) - for tmp in hiddentemplatesRaw] + self.hiddentemplates = set([pywikibot.Page(self.site, tmp) + for tmp in hiddentemplatesRaw]) self.pageHidden = pywikibot.translate(self.site, PageWithHiddenTemplates, fallback=False) @@ -836,10 +836,11 @@ def loadHiddenTemplates(self): """ Function to load the white templates """ - # A template as {{en is not a license! Adding also them in the whitelist template... + # A template as {{en is not a license! Adding also them in the + # whitelist template... for langK in pywikibot.Family(u'wikipedia').langs.keys(): - self.hiddentemplates.append(pywikibot.Page(self.site, - u'Template:%s' % langK)) + self.hiddentemplates.add(pywikibot.Page(self.site, + u'Template:%s' % langK)) # The template #if: and #switch: aren't something to care about #self.hiddentemplates.extend([u'#if:', u'#switch:']) FIXME @@ -853,7 +854,7 @@ pageHiddenText = '' for element in self.load(pageHiddenText): - self.hiddentemplates.append(pywikibot.Page(self.site, element)) + self.hiddentemplates.add(pywikibot.Page(self.site, element)) return self.hiddentemplates def returnOlderTime(self, listGiven, timeListGiven):