Il 10/08/2015 17:58, Merlijn van Deen ha scritto:
Hi Ricordisamoa,

On 10 August 2015 at 15:19, Ricordisamoa <ricordisamoa@openmailbox.org> wrote:
>>! In T106359#1506339, @Ciencia_Al_Poder wrote:
> Scoring your own patches with +1 is pointless since the point of code review is that //others// review your code. I'm pretty sure others know you approve your own patches, unless stated otherwise by marking the patch as "work in progress".

https://gerrit.wikimedia.org/r/#/q/project:pywikibot/core+owner:jayvdb%2540gmail.com+label:Code-Review%252B1%252Cuser%253Djayvdb%2540gmail.com,n,z

https://gerrit.wikimedia.org/r/#/q/project:pywikibot/core+owner:CommodoreFabianus%2540gmx.de+label:Code-Review%252B1%252Cuser%253DCommodoreFabianus%2540gmx.de,n,z

As far as I'm concerned, +1, -1 and -2 are all part of communication between reviewers and author. Do you feel the use of +1 as linked hampers your work as author or reviewer? This is not clear to me from your e-mail.

Merlijn


Hi,
I'm not totally against +1 on own patches, but I've seen it used a bit lightly.