jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/362235 )
Change subject: [Bugfix] Fix interwiki conflict detection
......................................................................
[Bugfix] Fix interwiki conflict detection
I think the previous code was error. If set of wikis linked
via interwiki is subset of those linked via Wikidata, it's ok.
The correct operation should be subtraction, ie. whether there
is something we have and Wikidata does not.
Bug: T168575
Change-Id: I92768d5ab975e9d698d79e938a20088c0dba56e4
---
M scripts/interwikidata.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/scripts/interwikidata.py b/scripts/interwikidata.py
index f4c23d5..ebd1723 100644
--- a/scripts/interwikidata.py
+++ b/scripts/interwikidata.py
@@ -142,7 +142,7 @@
if not self.iwlangs:
return
dbnames = [iw_site.dbName() for iw_site in self.iwlangs]
- if set(dbnames) < set(self.current_item.sitelinks.keys()):
+ if set(dbnames) - set(self.current_item.sitelinks.keys()):
if not self.handle_complicated():
warning('Interwiki conflict in %s, skipping...' %
self.current_page.title(asLink=True))
--
To view, visit
https://gerrit.wikimedia.org/r/362235
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92768d5ab975e9d698d79e938a20088c0dba56e4
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Matěj Suchánek <matejsuchanek97(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <Ladsgroup(a)gmail.com>
Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>