jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/354697 )
Change subject: Make the tests pass again: *
https://en.wikisource.org/w/index.php?type=revision&diff=6811951&ol…
made the number of validated pages increase *
https://en.wikipedia.org/w/index.php?type=revision&diff=780329438&o…
made the edit test
......................................................................
Make the tests pass again:
*
https://en.wikisource.org/w/index.php?type=revision&diff=6811951&ol…
made the number of validated pages increase
*
https://en.wikipedia.org/w/index.php?type=revision&diff=780329438&o…
made the edit test fail
* wikistats is broken, just disabled the tests
Bug: T165830
Change-Id: Iee6f815f7995eb6dc60d3a91f69fc24a6f101037
---
M tests/pagegenerators_tests.py
M tests/wikistats_tests.py
2 files changed, 6 insertions(+), 4 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py
index b24180d..6eaca83 100755
--- a/tests/pagegenerators_tests.py
+++ b/tests/pagegenerators_tests.py
@@ -238,7 +238,7 @@
site = self.site
gen = pagegenerators.PagesFromTitlesGenerator(self.titles, site)
gen = pagegenerators.CategoryFilterPageGenerator(gen, self.catfilter_list, site)
- self.assertEqual(len(tuple(gen)), 9)
+ self.assertEqual(len(tuple(gen)), 10)
class TestQualityFilterPageGenerator(TestCase):
@@ -314,12 +314,12 @@
gen, last_edit_end=two_days_ago)
self.assertEqual(len(list(gen)), 0)
- gen = PagesFromTitlesGenerator(['Template:Sidebox'], self.site)
+ gen = PagesFromTitlesGenerator(['Template:Side box'], self.site)
gen = pagegenerators.EdittimeFilterPageGenerator(
gen, last_edit_end=nine_days_ago)
self.assertEqual(len(list(gen)), 1)
- gen = PagesFromTitlesGenerator(['Template:Sidebox'], self.site)
+ gen = PagesFromTitlesGenerator(['Template:Side box'], self.site)
gen = pagegenerators.EdittimeFilterPageGenerator(
gen, last_edit_start=nine_days_ago)
self.assertEqual(len(list(gen)), 0)
diff --git a/tests/wikistats_tests.py b/tests/wikistats_tests.py
index f866eaf..c373ae3 100644
--- a/tests/wikistats_tests.py
+++ b/tests/wikistats_tests.py
@@ -1,7 +1,7 @@
# -*- coding: utf-8 -*-
"""Test cases for the WikiStats dataset."""
#
-# (C) Pywikibot team, 2014-2016
+# (C) Pywikibot team, 2014-2017
#
# Distributed under the terms of the MIT license.
#
@@ -15,6 +15,8 @@
from tests.aspects import unittest, TestCase
+(a)unittest.skip('Wikistats at
https://wikistats.wmflabs.org/ '
+ 'appears to be broken. See T165830.')
class WikiStatsTestCase(TestCase):
"""Test WikiStats dump."""
--
To view, visit
https://gerrit.wikimedia.org/r/354697
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee6f815f7995eb6dc60d3a91f69fc24a6f101037
Gerrit-PatchSet: 3
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Multichill <maarten(a)mdammers.nl>
Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>