jenkins-bot has submitted this change and it was merged.
Change subject: Additional tests for CC fixArabicLetters
......................................................................
Additional tests for CC fixArabicLetters
More coverage of functionality, especially of comma
exception.
Change-Id: I019e13bc91cd65554d609de47efeecfd94e24f08
---
M tests/cosmetic_changes_tests.py
1 file changed, 36 insertions(+), 2 deletions(-)
Approvals:
John Vandenberg: Looks good to me, but someone else must approve
Legoktm: Looks good to me, approved
AbdealiJK: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/tests/cosmetic_changes_tests.py b/tests/cosmetic_changes_tests.py
index 80a0595..1484904 100644
--- a/tests/cosmetic_changes_tests.py
+++ b/tests/cosmetic_changes_tests.py
@@ -300,12 +300,46 @@
family = 'wikipedia'
code = 'fa'
- def test_fixArabicLetters(self):
- """Test fixArabicLetters."""
+ def test_fixArabicLetters_comma(self):
+ """Test fixArabicLetters comma replacements."""
+ self.assertEqual(self.cct.fixArabicLetters(','), '،')
self.assertEqual(self.cct.fixArabicLetters('A,b,ا,۴,'),
'A,b،ا،۴،')
+
+ def test_fixArabicLetters_comma_skip(self):
+ """Test fixArabicLetters Latin comma not
replaced."""
+ self.assertEqual(self.cct.fixArabicLetters('a", b'), 'a",
b')
+ self.assertEqual(self.cct.fixArabicLetters('a, "b'), 'a,
"b')
+ self.assertEqual(self.cct.fixArabicLetters('a", "b'),
'a", "b')
+ # spaces are not required
+ self.assertEqual(self.cct.fixArabicLetters('a",b'),
'a",b')
+ self.assertEqual(self.cct.fixArabicLetters('a,"b'),
'a,"b')
+ self.assertEqual(self.cct.fixArabicLetters('a","b'),
'a","b')
+ # quotes are a 'non-Farsi' character; additional non-Farsi not needed
+ self.assertEqual(self.cct.fixArabicLetters('",b'),
'",b')
+ self.assertEqual(self.cct.fixArabicLetters('a,"'),
'a,"')
+ self.assertEqual(self.cct.fixArabicLetters('","'),
'","')
+
+ # A single quotation is a 'non-Farsi' character
+ self.assertEqual(self.cct.fixArabicLetters("',b"),
"',b")
+ self.assertEqual(self.cct.fixArabicLetters("a,'"),
"a,'")
+ self.assertEqual(self.cct.fixArabicLetters("','"),
"','")
+
+ # A space is a 'non-Farsi' character
+ self.assertEqual(self.cct.fixArabicLetters('a", ۴'), 'a",
۴')
+ self.assertEqual(self.cct.fixArabicLetters(' , '), ' , ')
+
+ def test_fixArabicLetters_letters(self):
+ """Test fixArabicLetters letter replacements."""
+ self.assertEqual(self.cct.fixArabicLetters('ك'),
+ 'ک')
+ self.assertEqual(self.cct.fixArabicLetters('ي'),
+ 'ی')
+ self.assertEqual(self.cct.fixArabicLetters('ى'),
+ 'ی')
self.assertEqual(self.cct.fixArabicLetters('كي'),
'کی')
+
# Once numbering fixes are enabled we can add tests.
if __name__ == '__main__':
--
To view, visit
https://gerrit.wikimedia.org/r/278599
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I019e13bc91cd65554d609de47efeecfd94e24f08
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: AbdealiJK <abdealikothari(a)gmail.com>
Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Legoktm <legoktm.wikipedia(a)gmail.com>
Gerrit-Reviewer: jenkins-bot <>