jenkins-bot has submitted this change and it was merged.
Change subject: Fix KeyError if package has been ignored
......................................................................
Fix KeyError if package has been ignored
The 'paths' dict is used to find packages which might
match the location of pywikibot. However it contained paths of
some packages which have already been skipped, and therefore
dont need to be excluded as pywikibot sub-modules.
Change-Id: I4f87941a61d2834e89791becf0181eb9a8ce8271
---
M pywikibot/version.py
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
XZise: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/version.py b/pywikibot/version.py
index 2229075..ce95775 100644
--- a/pywikibot/version.py
+++ b/pywikibot/version.py
@@ -371,10 +371,13 @@
(standard_lib is None and name in std_lib_packages):
if 'ver' in info:
data[name] = info
+ else:
+ # Remove the entry from paths, so it isnt processed below
+ del paths[info['path']]
else:
data[name] = info
- # Remove any sub-modules which were loaded with a different name.
+ # Remove any pywikibot sub-modules which were loaded as a package.
# e.g. 'wikipedia_family.py' is loaded as 'wikipedia'
_program_dir = _get_program_dir()
for path, name in paths.items():
--
To view, visit
https://gerrit.wikimedia.org/r/185953
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f87941a61d2834e89791becf0181eb9a8ce8271
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: XZise <CommodoreFabianus(a)gmx.de>
Gerrit-Reviewer: jenkins-bot <>