jenkins-bot has submitted this change and it was merged.
Change subject: Only set mwparserfromhell as a dependency for non-Windows users
......................................................................
Only set mwparserfromhell as a dependency for non-Windows users
Bug: 66010
Change-Id: Ice7a6650e03d743f72daabd51511a9af32eb0a5d
---
M setup.py
1 file changed, 7 insertions(+), 4 deletions(-)
Approvals:
John Vandenberg: Looks good to me, but someone else must approve
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/setup.py b/setup.py
index 5752e0b..357a1fe 100644
--- a/setup.py
+++ b/setup.py
@@ -38,6 +38,12 @@
print("ERROR: Python 3.3 or higher is required!")
sys.exit(1)
+dependencies = ['httplib2>=0.6.0']
+if os.name != 'nt':
+ # See bug 66010, Windows users will have issues
+ # when trying to build the C modules.
+ dependencies.append('mwparserfromhell>=0.3.3')
+
class pwb_install(install.install):
"""
@@ -65,10 +71,7 @@
[package
for package in find_packages()
if package.startswith('pywikibot.')],
- install_requires=[
- 'httplib2>=0.6.0',
- 'mwparserfromhell>=0.3.3'
- ],
+ install_requires=dependencies,
dependency_links=[
'https://git.wikimedia.org/zip/?r=pywikibot/externals/httplib2.git&format=gz#egg=httplib2-0.8-pywikibot1'
],
--
To view, visit
https://gerrit.wikimedia.org/r/136702
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ice7a6650e03d743f72daabd51511a9af32eb0a5d
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipedia(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>