jenkins-bot has submitted this change and it was merged.
Change subject: movepages.py: prevent error message with from/to
......................................................................
movepages.py: prevent error message with from/to
Prevent to display error message:
ERROR: Unable to execute script because no generator was defined.
when -from -to are used to specify input.
Change-Id: I96a3cea2f0fd959379a0fc67d8ed5c978217eda1
---
M scripts/movepages.py
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/movepages.py b/scripts/movepages.py
index 00336b7..b276b9c 100755
--- a/scripts/movepages.py
+++ b/scripts/movepages.py
@@ -274,10 +274,12 @@
bot = MovePagesBot(preloadingGen, **options)
bot.run()
return True
- else:
- # in theory pairs could be missing too
+
+ if not fromToPairs:
pywikibot.bot.suggest_help(missing_generator=True)
return False
+ else:
+ return True
if __name__ == '__main__':
main()
--
To view, visit
https://gerrit.wikimedia.org/r/265639
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I96a3cea2f0fd959379a0fc67d8ed5c978217eda1
Gerrit-PatchSet: 4
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>