jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/362829 )
Change subject: [bugfix] illustratewikidata: rename page_image key in page_image_free
......................................................................
[bugfix] illustratewikidata: rename page_image key in page_image_free
The name of the key is no longer page_image but is now page_image_free.
So illustrate_wikidata.py is actually entirely broken.
Note: I don't think that we need, with this script, to get non-free images too. So
I'll just implement the rename, not the both elements key.
Bug: T169447
Change-Id: Ia28c472c88baaad68f0042057905a0dbcd433ec8
---
M scripts/illustrate_wikidata.py
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
jenkins-bot: Verified
Xqt: Looks good to me, approved
diff --git a/scripts/illustrate_wikidata.py b/scripts/illustrate_wikidata.py
index 81bd6ba..329fb4d 100755
--- a/scripts/illustrate_wikidata.py
+++ b/scripts/illustrate_wikidata.py
@@ -59,7 +59,7 @@
self.current_page = page
pywikibot.output(u'Found %s' % item.title())
- imagename = page.properties().get('page_image')
+ imagename = page.properties().get('page_image_free')
if not imagename:
return
@@ -79,8 +79,8 @@
image = pywikibot.FilePage(image.getRedirectTarget())
if not image.exists():
- pywikibot.output('[[%s]] doesn\'t exist so I can\'t link to
it'
- % (image.title(),))
+ pywikibot.output("%s doesn't exist so I can't link to it"
+ % image.title(asLink=True))
return
newclaim.setTarget(image)
--
To view, visit
https://gerrit.wikimedia.org/r/362829
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia28c472c88baaad68f0042057905a0dbcd433ec8
Gerrit-PatchSet: 2
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Framawiki <framawiki(a)tools.wmflabs.org>
Gerrit-Reviewer: Framawiki <framawiki(a)tools.wmflabs.org>
Gerrit-Reviewer: Magul <tomasz.magulski(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>