jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/753042 )
Change subject: [W0125] Use typing.TYPE_CHECKING instead of False
......................................................................
[W0125] Use typing.TYPE_CHECKING instead of False
Change-Id: I92990421d2e2b8349b048ee1ee72f89c494e219c
---
M pywikibot/_wbtypes.py
M pywikibot/bot.py
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
JJMC89: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/_wbtypes.py b/pywikibot/_wbtypes.py
index 863fad8..744d8af 100644
--- a/pywikibot/_wbtypes.py
+++ b/pywikibot/_wbtypes.py
@@ -6,11 +6,11 @@
#
import abc
import json
-from typing import Any, Optional
+from typing import Any, Optional, TYPE_CHECKING
from pywikibot.backports import Dict
-if False: # typing.TYPE_CHECKING
+if TYPE_CHECKING:
from pywikibot.site import DataSite
diff --git a/pywikibot/bot.py b/pywikibot/bot.py
index 7181014..ef061b2 100644
--- a/pywikibot/bot.py
+++ b/pywikibot/bot.py
@@ -106,7 +106,7 @@
from importlib import import_module
from pathlib import Path
from textwrap import fill
-from typing import Any, Optional, Union
+from typing import Any, Optional, TYPE_CHECKING, Union
from warnings import warn
import pywikibot
@@ -181,7 +181,7 @@
from pywikibot.tools._logging import LoggingFormatter
from pywikibot.tools.formatter import color_format
-if False: # typing.TYPE_CHECKING
+if TYPE_CHECKING:
from pywikibot.site import BaseSite
AnswerType = Union[
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/753042
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I92990421d2e2b8349b048ee1ee72f89c494e219c
Gerrit-Change-Number: 753042
Gerrit-PatchSet: 1
Gerrit-Owner: Xqt <info(a)gno.de>
Gerrit-Reviewer: JJMC89 <JJMC89.Wikimedia(a)gmail.com>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged