Xqt has submitted this change and it was merged. Change subject: final pep8 v1.4.6 fixes ...................................................................... final pep8 v1.4.6 fixes This commit makes pywikibot/core to pass the pep8 checks as of version 1.4.6. I have asked that version to be made available so we can deploy it on the Jenkins server, once done, I guess we can cause pep8 to block changes :) Change-Id: I38b5499f464dbe5375b9aa130d46c200438f4800 --- M pywikibot/config2.py M scripts/delete.py 2 files changed, 8 insertions(+), 6 deletions(-) Approvals: Xqt: Looks good to me, approved diff --git a/pywikibot/config2.py b/pywikibot/config2.py index 6c2687c..ee62581 100644 --- a/pywikibot/config2.py +++ b/pywikibot/config2.py @@ -143,7 +143,7 @@ exc_text += " Please check that user-config.py is stored in the correct location.\n" exc_text += " Directory where user-config.py is searched is determined as follows:\n\n" exc_text += " " + _get_base_dir.__doc__ - + raise RuntimeError(exc_text) return base_dir diff --git a/scripts/delete.py b/scripts/delete.py index 2114e57..0a8e8b0 100644 --- a/scripts/delete.py +++ b/scripts/delete.py @@ -32,10 +32,11 @@ import pywikibot from pywikibot import i18n, config, catlib, pagegenerators + class DeletionRobot: """ This robot allows deletion of pages en masse. """ - def __init__(self, generator, summary, always = False, undelete=True): + def __init__(self, generator, summary, always=False, undelete=True): """ Arguments: * generator - A page generator. * always - Delete without prompting? @@ -52,9 +53,10 @@ for page in self.generator: pywikibot.output(u'Processing page %s' % page.title()) if self.undelete: - page.undelete(self.summary, throttle = True) + page.undelete(self.summary, throttle=True) else: - page.delete(self.summary, not self.always, throttle = True) + page.delete(self.summary, not self.always, throttle=True) + def main(): genFactory = pagegenerators.GeneratorFactory() @@ -96,7 +98,7 @@ genFactory.handleArg(arg) if not summary: if arg.startswith('-category'): - summary = i18n.twtranslate(mysite, 'delete-from-category',{'page': pageName}) + summary = i18n.twtranslate(mysite, 'delete-from-category', {'page': pageName}) elif arg.startswith('-links'): summary = i18n.twtranslate(mysite, 'delete-linked-pages', {'page': pageName}) elif arg.startswith('-ref'): @@ -112,7 +114,7 @@ generator = pagegenerators.ImagesPageGenerator(page) if not summary: summary = pywikibot.input(u'Enter a reason for the %sdeletion:' - % ['', 'un'][undelete]) + % ['', 'un'][undelete]) if not generator: generator = genFactory.getCombinedGenerator() if not generator: -- To view, visit https://gerrit.wikimedia.org/r/85421 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38b5499f464dbe5375b9aa130d46c200438f4800 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Hashar <hashar(a)free.fr> Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com> Gerrit-Reviewer: Legoktm <legoktm.wikipedia(a)gmail.com> Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl> Gerrit-Reviewer: Xqt <info(a)gno.de> Gerrit-Reviewer: jenkins-bot