jenkins-bot has submitted this change and it was merged.
Change subject: site.py: Update Page._protections after calling Site.protect()
......................................................................
site.py: Update Page._protections after calling Site.protect()
- Update Page._protections using the available req.submit() data.
- Activate the respective unittest function which was previously marked
as an expected failure.
Bug: T78522
Change-Id: If1c4e57cd67fb4b4141338ee515ece77f1b92d70
---
M pywikibot/site.py
M tests/site_tests.py
2 files changed, 9 insertions(+), 2 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/site.py b/pywikibot/site.py
index 369972c..61d6765 100644
--- a/pywikibot/site.py
+++ b/pywikibot/site.py
@@ -5195,7 +5195,7 @@
req = self._simple_request(**parameters)
try:
- req.submit()
+ result = req.submit()
except api.APIError as err:
errdata = {
'site': self,
@@ -5207,6 +5207,14 @@
% err.code,
_logger)
raise
+ else:
+ protection = {}
+ for d in result['protect']['protections']:
+ expiry = d.pop('expiry')
+ ptype, level = d.popitem()
+ if level:
+ protection[ptype] = (level, expiry)
+ page._protection = protection
finally:
self.unlock_page(page)
diff --git a/tests/site_tests.py b/tests/site_tests.py
index 52b746e..989e940 100644
--- a/tests/site_tests.py
+++ b/tests/site_tests.py
@@ -1667,7 +1667,6 @@
write = True
sysop = True
- @unittest.expectedFailure
def test_protect(self):
"""Test the site.protect() method."""
site = self.get_site()
--
To view, visit
https://gerrit.wikimedia.org/r/268188
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If1c4e57cd67fb4b4141338ee515ece77f1b92d70
Gerrit-PatchSet: 4
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: Dalba <dalba.wiki(a)gmail.com>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Mpaa <mpaa.wiki(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot <>