Legoktm has submitted this change and it was merged. Change subject: Few more things for uppercase ids ...................................................................... Few more things for uppercase ids Change-Id: I9b28ee8c597836d37d6e71eb18474466b4e04033 --- M pywikibot/page.py M tests/wikibase_tests.py 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Legoktm: Verified; Looks good to me, approved diff --git a/pywikibot/page.py b/pywikibot/page.py index 3b250c0..b02879a 100644 --- a/pywikibot/page.py +++ b/pywikibot/page.py @@ -2673,7 +2673,7 @@ """ WikibasePage.__init__(self, source, title, ns=120) self.id = self.title(withNamespace=False).upper() - if not self.id.startswith(u'p'): + if not self.id.startswith(u'P'): raise ValueError(u"'%s' is not a property page!" % self.title()) def get(self, force=False, *args): @@ -2698,7 +2698,7 @@ def __init__(self, site, title): WikibasePage.__init__(self, site, title, ns=122) self.id = self.title(withNamespace=False).upper() - if not self.id.startswith(u'u'): + if not self.id.startswith(u'U'): raise ValueError(u"'%s' is not a query page!" % self.title()) diff --git a/tests/wikibase_tests.py b/tests/wikibase_tests.py index fa3facd..3896392 100644 --- a/tests/wikibase_tests.py +++ b/tests/wikibase_tests.py @@ -36,7 +36,7 @@ self.assertTrue('HomePage' in item.aliases['en']) self.assertEqual(item.namespace(), 0) item2 = pywikibot.ItemPage(repo, 'q5296') - self.assertEqual(item2.getID(), 'q5296') + self.assertEqual(item2.getID(), 'Q5296') self.assertEqual(item.labels['en'], 'Main Page') prop = pywikibot.PropertyPage(repo, 'Property:P21') self.assertEqual(prop.getType(), 'wikibase-item') @@ -60,7 +60,7 @@ def setUp(self): super(TestLinks, self).setUp() self.wdp = pywikibot.ItemPage(wikidata, 'Q60') - self.wdp.id = 'q60' + self.wdp.id = 'Q60' self.wdp._content = json.load(open(os.path.join(os.path.split(__file__)[0], 'pages', 'Q60_only_sitelinks.wd'))) self.wdp.get() -- To view, visit https://gerrit.wikimedia.org/r/83653 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b28ee8c597836d37d6e71eb18474466b4e04033 Gerrit-PatchSet: 1 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Legoktm <legoktm.wikipedia(a)gmail.com> Gerrit-Reviewer: Legoktm <legoktm.wikipedia(a)gmail.com> Gerrit-Reviewer: jenkins-bot