jenkins-bot has submitted this change and it was merged.
Change subject: call showHelp() instead of raising TypeError in coordinate_import.py
......................................................................
call showHelp() instead of raising TypeError in coordinate_import.py
bug: 68551
Change-Id: I18382e5b9a712c9d0889b5d852215ecde9ef6cd8
---
M scripts/coordinate_import.py
1 file changed, 5 insertions(+), 2 deletions(-)
Approvals:
John Vandenberg: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/coordinate_import.py b/scripts/coordinate_import.py
index 160686a..547d106 100644
--- a/scripts/coordinate_import.py
+++ b/scripts/coordinate_import.py
@@ -84,8 +84,11 @@
generator = gen.getCombinedGenerator()
- coordbot = CoordImportRobot(generator)
- coordbot.run()
+ if generator:
+ coordbot = CoordImportRobot(generator)
+ coordbot.run()
+ else:
+ pywikibot.showHelp()
if __name__ == "__main__":
main()
--
To view, visit
https://gerrit.wikimedia.org/r/149488
To unsubscribe, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I18382e5b9a712c9d0889b5d852215ecde9ef6cd8
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa <ricordisamoa(a)openmailbox.org>
Gerrit-Reviewer: John Vandenberg <jayvdb(a)gmail.com>
Gerrit-Reviewer: Ladsgroup <ladsgroup(a)gmail.com>
Gerrit-Reviewer: Merlijn van Deen <valhallasw(a)arctus.nl>
Gerrit-Reviewer: Multichill <maarten(a)mdammers.nl>
Gerrit-Reviewer: jenkins-bot <>