jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/403618 ) Change subject: [test] Don't check for socketIO client ...................................................................... [test] Don't check for socketIO client - rcstreams was dropped. RCStream is offline and does no longer serve events. It is senseless to check for socketIO_client anymore. Bug: T170534 Change-Id: Ia494f4cb112736afe716abbda406656dfeb6f4ec --- M tests/pagegenerators_tests.py 1 file changed, 1 insertion(+), 13 deletions(-) Approvals: Dalba: Looks good to me, approved jenkins-bot: Verified diff --git a/tests/pagegenerators_tests.py b/tests/pagegenerators_tests.py index d17f415..5dd0f69 100755 --- a/tests/pagegenerators_tests.py +++ b/tests/pagegenerators_tests.py @@ -12,8 +12,6 @@ import logging import sys -from distutils.version import LooseVersion - import pywikibot from pywikibot import pagegenerators, date @@ -1411,17 +1409,7 @@ super(EventStreamsPageGeneratorTestCase, cls).setUpClass() cls.client = 'sseclient' if not has_module(cls.client): - cls.client = 'socketIO_client' - try: - import socketIO_client - except ImportError: - raise unittest.SkipTest( - 'Neither sseclient nor socketIO_client is available') - if LooseVersion( - socketIO_client.__version__) >= LooseVersion('0.6.1'): - raise unittest.SkipTest( - 'socketIO_client %s not supported by Wikimedia-Stream' - % socketIO_client.__version__) + raise unittest.SkipTest('{0} is not available'.format(cls.client)) def test_RC_pagegenerator_result(self): """Test RC pagegenerator.""" -- To view, visit https://gerrit.wikimedia.org/r/403618 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia494f4cb112736afe716abbda406656dfeb6f4ec Gerrit-PatchSet: 2 Gerrit-Project: pywikibot/core Gerrit-Branch: master Gerrit-Owner: Xqt &lt;info(a)gno.de&gt; Gerrit-Reviewer: Dalba &lt;dalba.wiki(a)gmail.com&gt; Gerrit-Reviewer: John Vandenberg &lt;jayvdb(a)gmail.com&gt; Gerrit-Reviewer: Krinkle &lt;krinklemail(a)gmail.com&gt; Gerrit-Reviewer: Merlijn van Deen &lt;valhallasw(a)arctus.nl&gt; Gerrit-Reviewer: Zoranzoki21 &lt;zorandori4444(a)gmail.com&gt; Gerrit-Reviewer: jenkins-bot <>