jenkins-bot has submitted this change. (
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/622811 )
Change subject: [bugfix] Clean up ProofreadPage.text
......................................................................
[bugfix] Clean up ProofreadPage.text
BasePage._text doesn't cache the live content anymore,
so don't rely on the internal side effect and just
return the value from the parent.
Bug: T260472
Change-Id: I21e4f234ac75237524d1d8c29c07efe0c45040bf
---
M pywikibot/proofreadpage.py
1 file changed, 7 insertions(+), 6 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/pywikibot/proofreadpage.py b/pywikibot/proofreadpage.py
index 8976b43..bf1858b 100644
--- a/pywikibot/proofreadpage.py
+++ b/pywikibot/proofreadpage.py
@@ -412,15 +412,16 @@
pages.
"""
# Text is already cached.
- if hasattr(self, '_text'):
+ if getattr(self, '_text', None) is not None:
return self._text
- # If page does not exist, preload it.
+
if self.exists():
# If page exists, load it.
- super().text
- else:
- self._text = self.preloadText()
- self.user = self.site.username() # Fill user field in empty header
+ return super().text
+
+ # If page does not exist, preload it.
+ self._text = self.preloadText()
+ self.user = self.site.username() # Fill user field in empty header
return self._text
@text.setter
--
To view, visit
https://gerrit.wikimedia.org/r/c/pywikibot/core/+/622811
To unsubscribe, or for help writing mail filters, visit
https://gerrit.wikimedia.org/r/settings
Gerrit-Project: pywikibot/core
Gerrit-Branch: master
Gerrit-Change-Id: I21e4f234ac75237524d1d8c29c07efe0c45040bf
Gerrit-Change-Number: 622811
Gerrit-PatchSet: 1
Gerrit-Owner: Matěj Suchánek <matejsuchanek97(a)gmail.com>
Gerrit-Reviewer: Xqt <info(a)gno.de>
Gerrit-Reviewer: jenkins-bot
Gerrit-MessageType: merged